Issue 553042: Attempt to fix a flaky test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 553042: Attempt to fix a flaky test (Closed)

Created:
10 years, 11 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
jcampan, Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Try to fix flaky test (FindMovesIfObscuring). I've run this through the try bots three times and they seemed to like the patch. BUG=16447 TEST=The change is to a test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36781

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -38 lines)			Patch
	M	chrome/browser/views/find_bar_host_browsertest.cc	View	1	1 chunk	+20 lines, -31 lines	1 comment	Download
	M	chrome/test/data/find_in_page/move_if_obscuring.html	View	1	1 chunk	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

10 years, 11 months ago (2010-01-21 20:41:55 UTC) #3

Drive-by, and thanks!

http://codereview.chromium.org/553042/diff/3001/3003
File chrome/browser/views/find_bar_host_browsertest.cc (right):

http://codereview.chromium.org/553042/diff/3001/3003#newcode579
chrome/browser/views/find_bar_host_browsertest.cc:579: for (; index < 30;
++index) {
nit: Could you make 30 a constant (kIterations)?

Expand Messages | Collapse Messages