Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 553042: Attempt to fix a flaky test (Closed)

Created:
10 years, 11 months ago by Finnur
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Try to fix flaky test (FindMovesIfObscuring). I've run this through the try bots three times and they seemed to like the patch. BUG=16447 TEST=The change is to a test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36781

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -38 lines) Patch
M chrome/browser/views/find_bar_host_browsertest.cc View 1 1 chunk +20 lines, -31 lines 1 comment Download
M chrome/test/data/find_in_page/move_if_obscuring.html View 1 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Finnur
10 years, 11 months ago (2010-01-21 20:14:05 UTC) #1
jcampan
LGTM
10 years, 11 months ago (2010-01-21 20:17:18 UTC) #2
Paweł Hajdan Jr.
10 years, 11 months ago (2010-01-21 20:41:55 UTC) #3
Drive-by, and thanks!

http://codereview.chromium.org/553042/diff/3001/3003
File chrome/browser/views/find_bar_host_browsertest.cc (right):

http://codereview.chromium.org/553042/diff/3001/3003#newcode579
chrome/browser/views/find_bar_host_browsertest.cc:579: for (; index < 30;
++index) {
nit: Could you make 30 a constant (kIterations)?

Powered by Google App Engine
This is Rietveld 408576698