Whitelist checkbox on ChromeOS users settings page should be inverted.

Whitelist checkbox on ChromeOS users settings page should be inverted.

Text change in r67269 inverted the whitelist checkbox logic.
- Add an "inverted_pref" property to PrefCheckBox so that we could map a checkbox to user inverted pref value;
- Update user settings UI and messages;

BUG=chromium-os:9788
TEST=Verify fix for chromium-os:9788

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68249

[zel, 2010-12-04 00:02:14]

LGTM

...integrate it with 552d (just in case) and 597 as well

[arv (Not doing code reviews), 2010-12-06 19:48:55]

Adding inverted prefs seems bad. Can we just fix the prefs?

erik



On Fri, Dec 3, 2010 at 15:40,  <xiyuan@chromium.org> wrote:
> Reviewers: zel,
>
> Description:
> Whitelist checkbox on ChromeOS users settings page should be inverted.
>
> Text change in r67269 inverted the whitelist checkbox logic.
> - Add an "inverted_pref" property to PrefCheckBox so that we could map a
> checkbox to user inverted pref value;
> - Update user settings UI and messages;
>
> BUG=chromium-os:9788
> TEST=Verify fix for chromium-os:9788
>
> Please review this at http://codereview.chromium.org/5530005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/app/generated_resources.grd
>  M chrome/browser/chromeos/dom_ui/accounts_options_handler.cc
>  M chrome/browser/resources/options/chromeos_accounts_options.html
>  M chrome/browser/resources/options/chromeos_accounts_options.js
>  M chrome/browser/resources/options/pref_ui.js
>
>
>

[xiyuan, 2010-12-06 20:05:40]

Changing prefs would be a much bigger change and would not be a safe change for
the release.

I agree this is bad and filed a http://crosbug.com/10049 to clean it up. Maybe
in R10 after we have stabilized the design of users settings UI logic.

On 2010/12/06 19:48:55, arv wrote:
> Adding inverted prefs seems bad. Can we just fix the prefs?
> 
> erik
>