Implement preference and policy based content settings providers.

chrome/browser/content_settings/host_content_settings_map.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Maps hostnames to custom content settings.  Written on the UI thread and read
 // on any thread.  One instance per profile.
 
 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_HOST_CONTENT_SETTINGS_MAP_H_
 #define CHROME_BROWSER_CONTENT_SETTINGS_HOST_CONTENT_SETTINGS_MAP_H_
 #pragma once
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/lock.h"
 #include "base/ref_counted.h"
+#include "base/stl_util-inl.h"
 #include "chrome/browser/browser_thread.h"
 #include "chrome/browser/content_settings/content_settings_pattern.h"
 #include "chrome/browser/prefs/pref_change_registrar.h"
 #include "chrome/common/content_settings.h"
 #include "chrome/common/notification_observer.h"
 #include "chrome/common/notification_registrar.h"
 
 class ContentSettingsDetails;
+class ContentSettingsProviderInterface;
 class DictionaryValue;
 class GURL;
 class PrefService;
 class Profile;
 
 class HostContentSettingsMap
     : public NotificationObserver,
       public base::RefCountedThreadSafe<HostContentSettingsMap,
                                         BrowserThread::DeleteOnUIThread> {
  public:
@@ skipping 112 matching lines @@
   void SetBlockThirdPartyCookies(bool block);
 
   bool GetBlockNonsandboxedPlugins() const {
     return block_nonsandboxed_plugins_;
   }
 
   void SetBlockNonsandboxedPlugins(bool block);
 
   // Resets all settings levels.
   //
   // This should only be called on the UI thread.

[gfeher, 2010/12/08 13:59:17]

I know this was already here, but please document that this is only used in
tests.

[gfeher, 2010/12/08 14:13:54]

Sorry, this is not true.

[jochen (gone - plz use gerrit), 2010/12/08 14:54:01]

right :)

   void ResetToDefaults();
 
   // Returns true if the default setting for the |content_type| is managed.
   bool IsDefaultContentSettingManaged(ContentSettingsType content_type) const;
 
-  // NotificationObserver implementation.
-  virtual void Observe(NotificationType type,
-                       const NotificationSource& source,
-                       const NotificationDetails& details);
-
  private:
   friend class base::RefCountedThreadSafe<HostContentSettingsMap>;
 
   typedef std::pair<ContentSettingsType, std::string>
       ContentSettingsTypeResourceIdentifierPair;
   typedef std::map<ContentSettingsTypeResourceIdentifierPair, ContentSetting>
       ResourceContentSettings;
 
   struct ExtendedContentSettings;
   typedef std::map<std::string, ExtendedContentSettings> HostContentSettings;
 
   // Sets the fields of |settings| based on the values in |dictionary|.
   void GetSettingsFromDictionary(const DictionaryValue* dictionary,
                                  ContentSettings* settings);
 
   // Populates |settings| based on the values in |dictionary|.
   void GetResourceSettingsFromDictionary(const DictionaryValue* dictionary,
                                          ResourceContentSettings* settings);
 
-  // Forces the default settings to be explicitly set instead of themselves
-  // being CONTENT_SETTING_DEFAULT.
-  void ForceDefaultsToBeExplicit();
-
   // Returns true if |settings| consists entirely of CONTENT_SETTING_DEFAULT.
   bool AllDefault(const ExtendedContentSettings& settings) const;
 
-  // Reads the default settings from the prefereces service. If |overwrite| is
-  // true and the preference is missing, the local copy will be cleared as well.
-  void ReadDefaultSettings(bool overwrite);
-
-  // Reads managed default content settings from the preference service |prefs|.
-  // |settings| is set to the respective content setting for managed settings,
-  // and to CONTENT_SETTING_DEFAULT for other settings.
-  void ReadManagedDefaultSettings(const PrefService* prefs,
-                                  ContentSettings* settings);
-
-  // Updates the managed setting of the default-content-settings-type |type|.
-  // The updated setting is read from the preference service |prefs| and written
-  // to |settings|.
-  void UpdateManagedDefaultSetting(ContentSettingsType type,
-                                   const PrefService* prefs,
-                                   ContentSettings* settings);
-
   // Reads the host exceptions from the prefereces service. If |overwrite| is
   // true and the preference is missing, the local copy will be cleared as well.
   void ReadExceptions(bool overwrite);
 
+  // NotificationObserver implementation.
+  virtual void Observe(NotificationType type,
+                       const NotificationSource& source,
+                       const NotificationDetails& details);
+
   // Informs observers that content settings have changed. Make sure that
   // |lock_| is not held when calling this, as listeners will usually call one
   // of the GetSettings functions in response, which would then lead to a
   // mutex deadlock.
   void NotifyObservers(const ContentSettingsDetails& details);
 
   void UnregisterObservers();
 
   // Various migration methods (old cookie, popup and per-host data gets
   // migrated to the new format).
   void MigrateObsoleteCookiePref(PrefService* prefs);
   void MigrateObsoletePopupsPref(PrefService* prefs);
   void MigrateObsoletePerhostPref(PrefService* prefs);
 
   // Converts all exceptions that have non-canonicalized pattern into
   // canonicalized pattern. If such pattern already exists, we just remove the
   // old exception.
   void CanonicalizeContentSettingsExceptions(DictionaryValue* settings);
 
   // The profile we're associated with.
   Profile* profile_;
 
   NotificationRegistrar notification_registrar_;
   PrefChangeRegistrar pref_change_registrar_;
 
+  // Content setting providers.
+  std::vector<ContentSettingsProviderInterface*> content_settings_providers_;
+  STLElementDeleter<std::vector<ContentSettingsProviderInterface*> >
+      content_settings_providers_deleter_;

[gfeher, 2010/12/08 13:59:17]

What was the reason for not using linked_ptr or something like that?

[jochen (gone - plz use gerrit), 2010/12/08 14:54:01]

Done.

+
   // Copies of the pref data, so that we can read it on the IO thread.
-  ContentSettings default_content_settings_;
   ContentSettings managed_default_content_settings_;
   HostContentSettings host_content_settings_;
 
   // Differences to the preference-stored host content settings for
   // off-the-record settings.
   HostContentSettings off_the_record_settings_;
 
   // Misc global settings.
   bool block_third_party_cookies_;
   bool is_block_third_party_cookies_managed_;
   bool block_nonsandboxed_plugins_;
 
   // Used around accesses to the settings objects to guarantee thread safety.

[gfeher, 2010/12/08 13:59:17]

Please list here what members are protected with this lock. (I've found it hard
in the .cc file to figure this out and verify.)

[jochen (gone - plz use gerrit), 2010/12/08 14:54:01]

Done.

   mutable Lock lock_;
 
   // Whether this settings map is for an OTR session.
   bool is_off_the_record_;
 
   // Whether we are currently updating preferences, this is used to ignore
   // notifications from the preferences service that we triggered ourself.
   bool updating_preferences_;
 
   DISALLOW_COPY_AND_ASSIGN(HostContentSettingsMap);
 };
 
 #endif  // CHROME_BROWSER_CONTENT_SETTINGS_HOST_CONTENT_SETTINGS_MAP_H_