Issue 5528007: If compositor window already exists, then simply return it rather than compla...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5528007: If compositor window already exists, then simply return it rather than compla... (Closed)

Created:
10 years ago by nduca

Modified:
9 years, 4 months ago

Reviewers:
apatrick, apatrick_chromium

CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

If compositor window already exists, then simply return it rather than complaining. May affect how bug 65194 manifests. BUG=65194 TEST=Verify against WebGL demos, poster circle content with tab opening and closing, as well as killing of GPU process. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68362

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -18 lines)			Patch
M	chrome/browser/gpu_process_host.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gpu_process_host.cc	View	1	4 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_win.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_win.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/test/test_render_view_host.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/test/test_render_view_host.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/gpu_messages_internal.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/gpu/gpu_command_buffer_stub.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

apatrick

10 years ago (2010-12-04 02:22:23 UTC) #2

Can you put the bug ID, 65194, on the BUG line of the description? Also, I trust
you tested this. You might want to mention how on the TEST line :)

One comment inline.

LGTM

http://codereview.chromium.org/5528007/diff/4001/chrome/browser/gpu_process_h...
File chrome/browser/gpu_process_host.h (right):

http://codereview.chromium.org/5528007/diff/4001/chrome/browser/gpu_process_h...
chrome/browser/gpu_process_host.h:99: int render_view_id,
indentation

Expand Messages | Collapse Messages