Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: chrome/common/extensions/extension_message_bundle.cc

Issue 5527004: Access singletons with a new GetInstance() method instead of Singleton<T>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_message_bundle.h" 5 #include "chrome/common/extensions/extension_message_bundle.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "app/l10n_util.h" 10 #include "app/l10n_util.h"
11 #include "base/hash_tables.h" 11 #include "base/hash_tables.h"
12 #include "base/i18n/rtl.h" 12 #include "base/i18n/rtl.h"
13 #include "base/lazy_instance.h"
13 #include "base/linked_ptr.h" 14 #include "base/linked_ptr.h"
14 #include "base/scoped_ptr.h" 15 #include "base/scoped_ptr.h"
15 #include "base/singleton.h"
16 #include "base/stl_util-inl.h" 16 #include "base/stl_util-inl.h"
17 #include "base/string_util.h" 17 #include "base/string_util.h"
18 #include "base/utf_string_conversions.h" 18 #include "base/utf_string_conversions.h"
19 #include "base/values.h" 19 #include "base/values.h"
20 #include "chrome/common/extensions/extension_constants.h" 20 #include "chrome/common/extensions/extension_constants.h"
21 #include "chrome/common/extensions/extension_error_utils.h" 21 #include "chrome/common/extensions/extension_error_utils.h"
22 #include "chrome/common/extensions/extension_l10n_util.h" 22 #include "chrome/common/extensions/extension_l10n_util.h"
23 23
24 namespace errors = extension_manifest_errors; 24 namespace errors = extension_manifest_errors;
25 25
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 309
310 return ""; 310 return "";
311 } 311 }
312 312
313 /////////////////////////////////////////////////////////////////////////////// 313 ///////////////////////////////////////////////////////////////////////////////
314 // 314 //
315 // Renderer helper functions. 315 // Renderer helper functions.
316 // 316 //
317 /////////////////////////////////////////////////////////////////////////////// 317 ///////////////////////////////////////////////////////////////////////////////
318 318
319 // Unique class for Singleton.
320 struct ExtensionToMessagesMap {
321 ExtensionToMessagesMap();
322 ~ExtensionToMessagesMap();
323
324 // Maps extension ID to message map.
325 ExtensionToL10nMessagesMap messages_map;
326 };
327
328 static base::LazyInstance<ExtensionToMessagesMap> g_extension_to_messages_map(
329 base::LINKER_INITIALIZED);
330
319 ExtensionToMessagesMap::ExtensionToMessagesMap() {} 331 ExtensionToMessagesMap::ExtensionToMessagesMap() {}
320 332
321 ExtensionToMessagesMap::~ExtensionToMessagesMap() {} 333 ExtensionToMessagesMap::~ExtensionToMessagesMap() {}
322 334
323 ExtensionToL10nMessagesMap* GetExtensionToL10nMessagesMap() { 335 ExtensionToL10nMessagesMap* GetExtensionToL10nMessagesMap() {
324 return &Singleton<ExtensionToMessagesMap>()->messages_map; 336 return &g_extension_to_messages_map.Get().messages_map;
325 } 337 }
326 338
327 L10nMessagesMap* GetL10nMessagesMap(const std::string extension_id) { 339 L10nMessagesMap* GetL10nMessagesMap(const std::string extension_id) {
328 ExtensionToL10nMessagesMap::iterator it = 340 ExtensionToL10nMessagesMap::iterator it =
329 Singleton<ExtensionToMessagesMap>()->messages_map.find(extension_id); 341 g_extension_to_messages_map.Get().messages_map.find(extension_id);
330 if (it != Singleton<ExtensionToMessagesMap>()->messages_map.end()) 342 if (it != g_extension_to_messages_map.Get().messages_map.end())
331 return &(it->second); 343 return &(it->second);
332 344
333 return NULL; 345 return NULL;
334 } 346 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698