Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5527003: Rename MediaFilter and MediaFilterCollection to Filter and FilterCollection, respectively. (Closed)

Created:
10 years ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), fbarchard, ddorwin+watch_chromium.org, Alpha Left Google, acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, awong, brettw-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., scherkus (not reviewing)
Visibility:
Public.

Description

Rename MediaFilter and MediaFilterCollection to Filter and FilterCollection, respectively. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68115

Patch Set 1 #

Patch Set 2 : Forgot some files #

Patch Set 3 : Missed a few more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -145 lines) Patch
M chrome/renderer/media/audio_renderer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/ipc_video_decoder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
A + media/base/filter_collection.h View 3 chunks +14 lines, -16 lines 0 comments Download
A + media/base/filter_collection.cc View 1 chunk +24 lines, -24 lines 0 comments Download
A + media/base/filter_collection_unittest.cc View 1 3 chunks +9 lines, -9 lines 0 comments Download
M media/base/filters.h View 8 chunks +12 lines, -12 lines 0 comments Download
M media/base/filters.cc View 5 chunks +17 lines, -17 lines 0 comments Download
M media/base/media_format.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/base/mock_filters.h View 1 8 chunks +10 lines, -10 lines 0 comments Download
M media/base/pipeline.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/base/pipeline_impl.h View 5 chunks +6 lines, -7 lines 0 comments Download
M media/base/pipeline_impl.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M media/base/pipeline_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_renderer_base.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_renderer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/decoder_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decoder_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/file_data_source.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/omx_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/video_renderer_base.h View 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M media/tools/player_wtl/movie.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/tools/player_x11/player_x11.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/media/buffered_data_source.h View 2 chunks +1 line, -2 lines 0 comments Download
M webkit/glue/media/buffered_data_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/media/simple_data_source.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/webmediaplayer_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/glue/webmediaplayer_impl.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/support/webkit_support.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scherkus (not reviewing)
10 years ago (2010-12-02 23:14:54 UTC) #1
scherkus (not reviewing)
This is another patch in my Make The Code More Enjoyable And Require Less Keystrokes(tm) ...
10 years ago (2010-12-02 23:16:12 UTC) #2
acolwell GONE FROM CHROMIUM
LGTM. It appears that webkit/glue/webmediaplayer_impl.cc needs a #include "media/base/filter_collection.h" based on the trybot output.
10 years ago (2010-12-02 23:41:26 UTC) #3
scherkus (not reviewing)
10 years ago (2010-12-02 23:42:38 UTC) #4 
yup I missed a few files :(

waiting for new try results

Powered by Google App Engine
This is Rietveld 408576698