Show extension tabs in task manager and correctly label apps.

chrome/browser/tab_contents/tab_contents.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/tab_contents.h"
 
 #include <cmath>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
@@ skipping 568 matching lines @@
 TabContentsSSLHelper* TabContents::GetSSLHelper() {
   if (ssl_helper_.get() == NULL)
     ssl_helper_.reset(new TabContentsSSLHelper(this));
   return ssl_helper_.get();
 }
 
 RenderProcessHost* TabContents::GetRenderProcessHost() const {
   return render_manager_.current_host()->process();
 }
 
+bool TabContents::IsInstalledApp() const {
+  ExtensionsService* extension_service = profile()->GetExtensionsService();
+
+  // Check for hosted app.
+  if (extension_service->GetExtensionByWebExtent(GetURL()) != NULL)
+    return true;
+
+  // Check for packaged app.
+  const Extension* extension =
+      extension_service->GetExtensionById(GetURL().host(), false);

[Erik does not do reviews, 2010/12/02 01:05:17]

use GetExtensionByURL instead (no need to use .host() then and it also checks
that the scheme is correct)

[Charlie Reis, 2010/12/02 01:45:43]

Ah, nice.  I should have noticed that one.

+  return extension != NULL && extension->is_app();
+}
+
 void TabContents::SetExtensionApp(const Extension* extension) {
   DCHECK(!extension || extension->GetFullLaunchURL().is_valid());
   extension_app_ = extension;
 
   UpdateExtensionAppIcon(extension_app_);
 
   NotificationService::current()->Notify(
       NotificationType::TAB_CONTENTS_APPLICATION_EXTENSION_CHANGED,
       Source<TabContents>(this),
       NotificationService::NoDetails());
@@ skipping 2641 matching lines @@
 }
 
 void TabContents::set_encoding(const std::string& encoding) {
   encoding_ = CharacterEncoding::GetCanonicalEncodingNameByAliasName(encoding);
 }
 
 void TabContents::SetAppIcon(const SkBitmap& app_icon) {
   app_icon_ = app_icon;
   NotifyNavigationStateChanged(INVALIDATE_TITLE);
 }