Issue 5524006: Irregexp: Preload more characters when we are not at the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5524006: Irregexp: Preload more characters when we are not at the... (Closed)

Created:
10 years ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Irregexp: Preload more characters when we are not at the start of the input and some alternations in the disjunction are anchored. Committed: http://code.google.com/p/v8/source/detail?r=5915

Patch Set 1 #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -30 lines)			Patch
	M	src/jsregexp.h	View		10 chunks	+30 lines, -11 lines	2 comments	Download
	M	src/jsregexp.cc	View		5 chunks	+57 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/5524006/diff/1/src/jsregexp.h File src/jsregexp.h (right): http://codereview.chromium.org/5524006/diff/1/src/jsregexp.h#newcode600 src/jsregexp.h:600: virtual int EatsAtLeast(int still_to_find, Add explanation of not_at_start ...

10 years ago (2010-12-03 09:12:43 UTC) #2

Erik Corry

10 years ago (2010-12-03 09:26:07 UTC) #3

http://codereview.chromium.org/5524006/diff/1/src/jsregexp.h
File src/jsregexp.h (right):

http://codereview.chromium.org/5524006/diff/1/src/jsregexp.h#newcode600
src/jsregexp.h:600: virtual int EatsAtLeast(int still_to_find,
On 2010/12/03 09:12:43, Lasse Reichstein wrote:
> Add explanation of not_at_start parameter - what happens if it's true vs.
false.
> Consider renaming to a positive name (at_start), or better something that
> captures the positive of "may be at start" vs. "definitly not at start".

I think I will explain, but not rename, since we use this polarity in many
places.

Expand Messages | Collapse Messages