Issue 5523001: Fix ClientSocketPoolBaseHelper preconnect crasher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5523001: Fix ClientSocketPoolBaseHelper preconnect crasher. (Closed)

Created:
10 years ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix ClientSocketPoolBaseHelper preconnect crasher. It's caused by an invalid read that sometimes leads to an invalid write that causes a CHECK failure. BUG=64985 TEST=New unit test added, fails under valgrind without the fix. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67942

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add NOTREACHED(). #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	net/socket/client_socket_pool_base.cc	View	1	1 chunk	+13 lines, -1 line	0 comments	Download
	M	net/socket/client_socket_pool_base_unittest.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

Here's crasher fix #1. I currently believe there is another crasher I haven't found yet. ...

10 years ago (2010-12-01 23:56:44 UTC) #1

Mike Belshe

LGTM http://codereview.chromium.org/5523001/diff/1/net/socket/client_socket_pool_base.cc File net/socket/client_socket_pool_base.cc (right): http://codereview.chromium.org/5523001/diff/1/net/socket/client_socket_pool_base.cc#newcode261 net/socket/client_socket_pool_base.cc:261: // error. If this is unexpected, should we ...

10 years ago (2010-12-02 00:02:36 UTC) #2

willchan no longer on Chromium

10 years ago (2010-12-02 00:14:00 UTC) #3

Heh, I coulda sworn I had a NOTREACHED() there before.  Musta deleted it on
accident during a refactor.

http://codereview.chromium.org/5523001/diff/1/net/socket/client_socket_pool_b...
File net/socket/client_socket_pool_base.cc (right):

http://codereview.chromium.org/5523001/diff/1/net/socket/client_socket_pool_b...
net/socket/client_socket_pool_base.cc:261: // error.
On 2010/12/02 00:02:36, Mike Belshe wrote:
> If this is unexpected, should we have a NOTREACHED() or DCHECK?

Done.

Expand Messages | Collapse Messages