Issue 5522007: ChromeOS status text halo polish.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5522007: ChromeOS status text halo polish. (Closed)

Created:
10 years ago by xiyuan

Modified:
9 years, 7 months ago

Reviewers:
DaveMoore

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ChromeOS status text halo polish. - Fix the spikes on text of certain font by using round line join instead of default mitter join; - Use the same 0.7 black as other icons instead of 1.0 black; BUG=chromium-os:9787 TEST=Verify fix for chromium-os:9787 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68255

Patch Set 1 #

Total comments: 2

Patch Set 2 : address davemoore's comment #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/browser/chromeos/status/status_area_button.cc	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
	M	gfx/canvas_skia_linux.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

xiyuan

A screenshot of what I get now is attached with the bug: http://crosbug.com/9787.

10 years ago (2010-12-02 23:13:28 UTC) #1

DaveMoore

LGTM modulo nit http://codereview.chromium.org/5522007/diff/1/chrome/browser/chromeos/status/status_area_button.cc File chrome/browser/chromeos/status/status_area_button.cc (right): http://codereview.chromium.org/5522007/diff/1/chrome/browser/chromeos/status/status_area_button.cc#newcode27 chrome/browser/chromeos/status/status_area_button.cc:27: SetTextHaloColor(SkColorSetARGB(0xB3, 0, 0, 0)); Could you ...

10 years ago (2010-12-04 00:08:01 UTC) #2

xiyuan

10 years ago (2010-12-04 00:35:21 UTC) #3

http://codereview.chromium.org/5522007/diff/1/chrome/browser/chromeos/status/...
File chrome/browser/chromeos/status/status_area_button.cc (right):

http://codereview.chromium.org/5522007/diff/1/chrome/browser/chromeos/status/...
chrome/browser/chromeos/status/status_area_button.cc:27:
SetTextHaloColor(SkColorSetARGB(0xB3, 0, 0, 0));
On 2010/12/04 00:08:02, davemoore wrote:
> Could you make this a constant?

Done.

Expand Messages | Collapse Messages