Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: net/proxy/proxy_list.h

Issue 552164: Merge 34903, 34928, 35008, 35549, 36054 to the 249s branch.... (Closed) Base URL: svn://chrome-svn/chrome/branches/249s/src/
Patch Set: Fix some other merge conflicts Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_info.cc ('k') | net/proxy/proxy_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_list.h
===================================================================
--- net/proxy/proxy_list.h (revision 37149)
+++ net/proxy/proxy_list.h (working copy)
@@ -25,16 +25,21 @@
// Set the proxy list to a single entry, |proxy_server|.
void SetSingleProxyServer(const ProxyServer& proxy_server);
- // Remove all proxies known to be bad from the proxy list.
- void RemoveBadProxies(const ProxyRetryInfoMap& proxy_retry_info);
+ // De-prioritizes the proxies that we have cached as not working, by moving
+ // them to the end of the fallback list.
+ void DeprioritizeBadProxies(const ProxyRetryInfoMap& proxy_retry_info);
// Delete any entry which doesn't have one of the specified proxy schemes.
// |scheme_bit_field| is a bunch of ProxyServer::Scheme bitwise ORed together.
void RemoveProxiesWithoutScheme(int scheme_bit_field);
- // Returns the first valid proxy server in the list.
- ProxyServer Get() const;
+ // Returns true if there is nothing left in the ProxyList.
+ bool IsEmpty() const;
+ // Returns the first proxy server in the list. It is only valid to call
+ // this if !IsEmpty().
+ const ProxyServer& Get() const;
+
// Set the list by parsing the pac result |pac_string|.
// Some examples for |pac_string|:
// "DIRECT"
Property changes on: net\proxy\proxy_list.h
___________________________________________________________________
Modified: svn:mergeinfo
Merged /trunk/src/net/proxy/proxy_list.h:r34903,34928,35008,35549,36054
« no previous file with comments | « net/proxy/proxy_info.cc ('k') | net/proxy/proxy_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698