Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Unified Diff: net/proxy/proxy_service.h

Issue 552164: Merge 34903, 34928, 35008, 35549, 36054 to the 249s branch.... (Closed) Base URL: svn://chrome-svn/chrome/branches/249s/src/
Patch Set: Fix some other merge conflicts Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_server.h ('k') | net/proxy/proxy_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_service.h
===================================================================
--- net/proxy/proxy_service.h (revision 37149)
+++ net/proxy/proxy_service.h (working copy)
@@ -217,11 +217,12 @@
// Removes |req| from the list of pending requests.
void RemovePendingRequest(PacRequest* req);
- // Called to indicate that a PacRequest completed. The |config_id| parameter
- // indicates the proxy configuration that was queried. |result_code| is OK
- // if the PAC file could be downloaded and executed. Otherwise, it is an
- // error code, indicating a bad proxy configuration.
- void DidCompletePacRequest(int config_id, int result_code);
+ // Called when proxy resolution has completed (either synchronously or
+ // asynchronously). Handles logging the result, and cleaning out
+ // bad entries from the results list.
+ int DidFinishResolvingProxy(ProxyInfo* result,
+ int result_code,
+ LoadLog* load_log);
// Returns true if the URL passed in should not go through the proxy server.
// 1. If the proxy settings say to bypass local names, and |IsLocalName(url)|.
@@ -248,9 +249,6 @@
// Increasing ID to give to the next ProxyConfig that we set.
int next_config_id_;
- // Indicates that the configuration is bad and should be ignored.
- bool config_is_bad_;
-
// Indicates whether the ProxyResolver should be sent requests.
bool should_use_proxy_resolver_;
« no previous file with comments | « net/proxy/proxy_server.h ('k') | net/proxy/proxy_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698