Add an implementation for async_network_alive to Linux

Add an implementation for async_network_alive to Linux

BUG=33091
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37342

[akalin, 2010-01-27 01:24:50]

Add a comment about how this is copied from syncapi.cc.

I'm not an expert on this (I just compared with what's in syncapi.cc) so I'd be
more comfortable if you got whoever looked at the syncapi.cc implementation to
also look at this.

http://codereview.chromium.org/552162/diff/1/2
File chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc
(right):

http://codereview.chromium.org/552162/diff/1/2#newcode20
chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:20: if
(pipe(exit_pipe_) == -1) {
PLOG(ERROR) something here

http://codereview.chromium.org/552162/diff/1/2#newcode27
chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:27:
close(exit_pipe_[1]);
shouldn't this condition on exit_pipe_[1]

http://codereview.chromium.org/552162/diff/1/2#newcode61
chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:61:
LOG(ERROR) << "select() returned unexpected result " << result;
PLOG

http://codereview.chromium.org/552162/diff/1/2#newcode87
chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:87: // If
there is an active connection, check that www.google.com:80
fix comment to say talk.google.com

http://codereview.chromium.org/552162/diff/1/2#newcode105
chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:105:
LOG(WARNING) << "Error sending error signal to AsyncNetworkAliveLinux";
PLOG

[Zachary Kuznia, 2010-01-27 22:33:29]

http://codereview.chromium.org/552162/diff/1/2
File chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc
(right):

http://codereview.chromium.org/552162/diff/1/2#newcode20
chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:20: if
(pipe(exit_pipe_) == -1) {
On 2010/01/27 01:24:50, akalin wrote:
> PLOG(ERROR) something here

Done.

http://codereview.chromium.org/552162/diff/1/2#newcode27
chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:27:
close(exit_pipe_[1]);
On 2010/01/27 01:24:50, akalin wrote:
> shouldn't this condition on exit_pipe_[1]

Done.

http://codereview.chromium.org/552162/diff/1/2#newcode61
chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:61:
LOG(ERROR) << "select() returned unexpected result " << result;
On 2010/01/27 01:24:50, akalin wrote:
> PLOG

Done.

http://codereview.chromium.org/552162/diff/1/2#newcode87
chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:87: // If
there is an active connection, check that www.google.com:80
On 2010/01/27 01:24:50, akalin wrote:
> fix comment to say http://talk.google.com

Done.

http://codereview.chromium.org/552162/diff/1/2#newcode105
chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:105:
LOG(WARNING) << "Error sending error signal to AsyncNetworkAliveLinux";
On 2010/01/27 01:24:50, akalin wrote:
> PLOG

Done.

[akalin, 2010-01-27 22:36:34]

LGTM.

On 2010/01/27 22:33:29, zork wrote:
> http://codereview.chromium.org/552162/diff/1/2
> File chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc
> (right):
> 
> http://codereview.chromium.org/552162/diff/1/2#newcode20
> chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:20: if
> (pipe(exit_pipe_) == -1) {
> On 2010/01/27 01:24:50, akalin wrote:
> > PLOG(ERROR) something here
> 
> Done.
> 
> http://codereview.chromium.org/552162/diff/1/2#newcode27
> chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:27:
> close(exit_pipe_[1]);
> On 2010/01/27 01:24:50, akalin wrote:
> > shouldn't this condition on exit_pipe_[1]
> 
> Done.
> 
> http://codereview.chromium.org/552162/diff/1/2#newcode61
> chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:61:
> LOG(ERROR) << "select() returned unexpected result " << result;
> On 2010/01/27 01:24:50, akalin wrote:
> > PLOG
> 
> Done.
> 
> http://codereview.chromium.org/552162/diff/1/2#newcode87
> chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:87: // If
> there is an active connection, check that http://www.google.com:80
> On 2010/01/27 01:24:50, akalin wrote:
> > fix comment to say http://talk.google.com
> 
> Done.
> 
> http://codereview.chromium.org/552162/diff/1/2#newcode105
> chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:105:
> LOG(WARNING) << "Error sending error signal to AsyncNetworkAliveLinux";
> On 2010/01/27 01:24:50, akalin wrote:
> > PLOG
> 
> Done.

[akalin, 2010-01-27 22:38:55]

oh and mention 33091 in the change description.

On 2010/01/27 22:36:34, akalin wrote:
> LGTM.
> 
> On 2010/01/27 22:33:29, zork wrote:
> > http://codereview.chromium.org/552162/diff/1/2
> > File chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc
> > (right):
> > 
> > http://codereview.chromium.org/552162/diff/1/2#newcode20
> > chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:20: if
> > (pipe(exit_pipe_) == -1) {
> > On 2010/01/27 01:24:50, akalin wrote:
> > > PLOG(ERROR) something here
> > 
> > Done.
> > 
> > http://codereview.chromium.org/552162/diff/1/2#newcode27
> > chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:27:
> > close(exit_pipe_[1]);
> > On 2010/01/27 01:24:50, akalin wrote:
> > > shouldn't this condition on exit_pipe_[1]
> > 
> > Done.
> > 
> > http://codereview.chromium.org/552162/diff/1/2#newcode61
> > chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:61:
> > LOG(ERROR) << "select() returned unexpected result " << result;
> > On 2010/01/27 01:24:50, akalin wrote:
> > > PLOG
> > 
> > Done.
> > 
> > http://codereview.chromium.org/552162/diff/1/2#newcode87
> > chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:87: //
If
> > there is an active connection, check that http://www.google.com:80
> > On 2010/01/27 01:24:50, akalin wrote:
> > > fix comment to say http://talk.google.com
> > 
> > Done.
> > 
> > http://codereview.chromium.org/552162/diff/1/2#newcode105
> > chrome/browser/sync/notifier/base/linux/async_network_alive_linux.cc:105:
> > LOG(WARNING) << "Error sending error signal to AsyncNetworkAliveLinux";
> > On 2010/01/27 01:24:50, akalin wrote:
> > > PLOG
> > 
> > Done.