gcl.py cleanup

gcl.py cleanup

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37053

[M-A Ruel, 2010-01-25 21:35:24]

Actually, gcl shouldn't have these defaults anymore. Wouldn't it be a good time
to remove this?

[Lei Zhang, 2010-01-25 21:52:16]

On 2010/01/25 21:35:24, Marc-Antoine Ruel wrote:
> Actually, gcl shouldn't have these defaults anymore. Wouldn't it be a good
time
> to remove this?

I guess it is.

[M-A Ruel, 2010-01-25 22:06:04]

http://codereview.chromium.org/552139/diff/3001/4
File gcl.py (left):

http://codereview.chromium.org/552139/diff/3001/4#oldcode32
gcl.py:32: "CODE_REVIEW_SERVER": "codereview.chromium.org",
Should we keep it with default to codereview.appspot.com ? It'd simplify the
code below since it assumes CODE_REVIEW_SERVER is always set.

[Lei Zhang, 2010-01-25 22:28:18]

On 2010/01/25 22:06:04, Marc-Antoine Ruel wrote:
> http://codereview.chromium.org/552139/diff/3001/4
> File gcl.py (left):
> 
> http://codereview.chromium.org/552139/diff/3001/4#oldcode32
> gcl.py:32: "CODE_REVIEW_SERVER": "codereview.chromium.org",
> Should we keep it with default to http://codereview.appspot.com ? It'd
simplify the
> code below since it assumes CODE_REVIEW_SERVER is always set.

Sounds like a reasonable default. Done.

[M-A Ruel, 2010-01-25 22:47:13]

lgtm

[jam, 2010-01-25 23:45:00]

I don't think this should have been switched (other than going from google
groups to chromium.org per the original patchset).  If someone uses gcl now
under the WebKit directory to put up a patch for Chrome people to look at it
before sending it to WebKit, it will show up on the wrong rietveld instance, and
won't cc the right emails etc.