Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 552101: Do not include chromeos/libcros.so in chrome-chromeos.zip. (Closed)

Created:
10 years, 11 months ago by satorux1
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_googlegroups.com, Yusuke Sato
Visibility:
Public.

Description

Do not include chromeos/libcros.so in chrome-chromeos.zip. The original pattern "chrome-chromeos/chrome*" was loose enough to include "chromeos/libcros.so" if it's present. The file should not be included in chrome-chromeos.zip file, which is used to build the chromeos-chrome deb package, since libcros.so is provided by the chromeos-libcros deb package. I had "chromium/src/out/Release/chromeos/libcros.so" to run the Chromium OS version of Chromium browser locally with libcros.so enabled. TEST=manually: % cd ../build/x86/local_assets % unzip -l chrome-chromeos.zip > before ... made this change ... % cd ../build/x86/local_assets unzip -l chrome-chromeos.zip > after % diff -u before after --- before 2010-01-22 13:53:39.361522119 +0900 +++ after 2010-01-22 13:54:52.117212719 +0900 @@ -2,8 +2,6 @@ Length Date Time Name --------- ---------- ----- ---- 12584626 2010-01-22 13:46 chrome-chromeos/candidate_window - 0 2010-01-22 13:13 chrome-chromeos/chromeos/ - 432316 2010-01-22 13:13 chrome-chromeos/chromeos/libcros.so 4850 2009-12-09 15:37 chrome-chromeos/product_logo_48.png 54594 2010-01-22 13:46 chrome-chromeos/session 0 2010-01-18 11:52 chrome-chromeos/resources/ @@ -220,4 +218,4 @@ 127262 2010-01-21 14:05 chrome-chromeos/locales/ro.pak 112422 2010-01-21 14:05 chrome-chromeos/locales/en-GB.pak --------- ------- - 66476904 218 files + 66044588 216 files

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/scripts/build_chrome.sh View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
10 years, 11 months ago (2010-01-22 05:11:40 UTC) #1
oshima
looks fine to me, but adding Randall just in case. Randall, can you review this ...
10 years, 11 months ago (2010-01-25 18:50:44 UTC) #2
satorux1
Friendly ping. Randall, could you take a look? On 2010/01/25 18:50:44, oshima wrote: > looks ...
10 years, 10 months ago (2010-02-08 05:55:32 UTC) #3
Randall Spangler
10 years, 10 months ago (2010-02-10 22:05:15 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698