Issue 5521005: AutoFillProfile: Don't clobber data on self-assignment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5521005: AutoFillProfile: Don't clobber data on self-assignment (Closed)

Created:
10 years ago by Ilya Sherman

Modified:
9 years, 7 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, James Hawkins, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

AutoFillProfile: Don't clobber data on self-assignment BUG=none TEST=unit_test --gtest_filter=AutoFillProfileTest.AssignmentOperator:CreditCardTest.AssignmentOperator Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68449

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -0 lines)			Patch
M	chrome/browser/autofill/autofill_profile.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/autofill_profile_unittest.cc	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/credit_card.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/credit_card_unittest.cc	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Ilya Sherman

Just added the code necessary for correctness, though I can add the other if-stmts too ...

10 years ago (2010-12-06 23:09:31 UTC) #1

dhollowa

On 2010/12/06 23:09:31, Ilya Sherman wrote: > Just added the code necessary for correctness, though ...

10 years ago (2010-12-07 01:50:42 UTC) #2

Ilya Sherman

On 2010/12/07 01:50:42, dhollowa wrote: > On 2010/12/06 23:09:31, Ilya Sherman wrote: > > Just ...

10 years ago (2010-12-07 01:54:58 UTC) #3

LGTM.