Issue 552089: A follow-up to fix 553: really report function object moves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 552089: A follow-up to fix 553: really report function object moves. (Closed)

Created:
10 years, 11 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

A follow-up to fix 553: really report function object moves. As an afterthought, I realized that I put function objects moves reporting into a method that deals with only code object moves. I've looked up that function objects are allocated in old pointer space and new space, so I moved logging to the corresponding VM methods. BUG=553 Committed: http://code.google.com/p/v8/source/detail?r=3679

Patch Set 1 #

Patch Set 2 : Add an assertion to test #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	src/mark-compact.cc	View		4 chunks	+11 lines, -3 lines	0 comments	Download
	M	test/cctest/test-log-stack-tracer.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages