Issue 552026: Revert 36459 - Breaks 7 WebKit tests...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 552026: Revert 36459 - Breaks 7 WebKit tests... (Closed)

Created:
10 years, 11 months ago by jschuh

Modified:
9 years, 6 months ago

Reviewers:
jschuh

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 36459 - Breaks 7 WebKit tests Changes are: * base::IsValidCodepoint() now returns false on noncharacter code points. * base::IsStringUTF8() now uses ICU library (removed old Mozilla implementation). * Removed base::IsStringWideUTF8() (was unused and confusing) * file_util::ReplaceIllegalCharactersInPath() now treats Unicode replacement character (U+FFFD) as invalid. * Associated unit tests updated. BUG=2759 BUG=30662 TEST=base_unittests gtest_filter=StringUtilTest.IsStringUTF8 TEST=base_unittests gtest_filter=UTFStringConversionsTest.* TEST=base_unittests gtest_filter=FileUtilICUTestReplaceIllegalCharactersInPathTest Review URL: http://codereview.chromium.org/548017 TBR=jschuh@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36460

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -29 lines)			Patch
M	base/i18n/file_util_icu.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	base/string_util.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	base/string_util.cc	View	2 chunks	+130 lines, -11 lines	0 comments	Download
M	base/string_util_unittest.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	base/utf_string_conversion_utils.h	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	base/utf_string_conversions_unittest.cc	View	4 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages