Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 552004: Style cleanup in preparation for auto-linting base/. (Closed)

Created:
10 years, 11 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org, brettw+cc_chromium.org, John Grabowski, Paweł Hajdan Jr.
Visibility:
Public.

Description

Style cleanup in preparation for auto-linting base/. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -167 lines) Patch
M base/at_exit.h View 1 chunk +1 line, -1 line 0 comments Download
M base/compat_execinfo.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/crypto/rsa_private_key.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/eintr_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M base/event_recorder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/file_descriptor_shuffle.h View 1 chunk +1 line, -1 line 0 comments Download
M base/image_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/keyboard_code_conversion_gtk.cc View 4 chunks +81 lines, -81 lines 0 comments Download
M base/lazy_instance_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M base/linked_ptr.h View 2 chunks +9 lines, -2 lines 0 comments Download
M base/logging_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/md5.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/message_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_pump_glib_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/object_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/observer_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/process_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/rand_util.h View 1 chunk +1 line, -1 line 0 comments Download
M base/registry.cc View 7 chunks +12 lines, -7 lines 0 comments Download
M base/resource_util.h View 1 chunk +1 line, -1 line 0 comments Download
M base/scoped_cftyperef.h View 1 chunk +1 line, -1 line 0 comments Download
M base/scoped_handle.h View 1 chunk +1 line, -1 line 0 comments Download
M base/scoped_handle_win.h View 1 chunk +1 line, -1 line 0 comments Download
M base/scoped_nsdisable_screen_updates.h View 1 chunk +1 line, -1 line 0 comments Download
M base/scoped_vector.h View 2 chunks +5 lines, -2 lines 0 comments Download
M base/sha2.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/simple_thread_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/spin_wait.h View 2 chunks +2 lines, -3 lines 0 comments Download
M base/stack_container_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/stats_table_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/string_piece.h View 1 chunk +8 lines, -2 lines 0 comments Download
M base/sync_socket_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_string_conversions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/perf_test_suite.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/test/test_file_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/test/test_suite.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/thread_local_storage.h View 1 chunk +1 line, -1 line 0 comments Download
M base/time_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/timer.h View 1 chunk +1 line, -1 line 0 comments Download
M base/timer_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M base/trace_event.h View 1 chunk +1 line, -1 line 0 comments Download
M base/tuple.h View 4 chunks +5 lines, -6 lines 0 comments Download
M base/values.h View 1 chunk +4 lines, -1 line 0 comments Download
M base/values_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/version.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/waitable_event_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/worker_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
Much easier to read the raw diff on this one.
10 years, 11 months ago (2010-01-14 22:11:13 UTC) #1
Elliot Glaysher
ONE WEEK PING.
10 years, 11 months ago (2010-01-26 18:51:47 UTC) #2
brettw
LGTM
10 years, 11 months ago (2010-01-26 20:28:49 UTC) #3
ki1023lou
6 years, 8 months ago (2014-04-23 17:32:58 UTC) #4
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/249363004/ by ki1023lou@gmail.com.

The reason for reverting is: ki1023lou@gmail.com
 dari mohamed
 n.tèl : +213555346193.

Powered by Google App Engine
This is Rietveld 408576698