Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: chrome/browser/dom_ui/chrome_url_data_manager.cc

Issue 5519016: Add a new GetInstance() method for singleton classes used in chrome/browser files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/chrome_url_data_manager.h ('k') | chrome/browser/dom_ui/conflicts_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/chrome_url_data_manager.cc
diff --git a/chrome/browser/dom_ui/chrome_url_data_manager.cc b/chrome/browser/dom_ui/chrome_url_data_manager.cc
index 2e6cec9d5256e3f9bcb3aafb8e5a35527f3c5f57..615345856c5345b20d925c63352ce89a8c8dca59 100644
--- a/chrome/browser/dom_ui/chrome_url_data_manager.cc
+++ b/chrome/browser/dom_ui/chrome_url_data_manager.cc
@@ -96,7 +96,7 @@ class URLRequestChromeFileJob : public URLRequestFileJob {
void RegisterURLRequestChromeJob() {
FilePath inspector_dir;
if (PathService::Get(chrome::DIR_INSPECTOR, &inspector_dir)) {
- Singleton<ChromeURLDataManager>()->AddFileSource(
+ ChromeURLDataManager::GetInstance()->AddFileSource(
chrome::kChromeUIDevToolsHost, inspector_dir);
}
@@ -110,7 +110,7 @@ void RegisterURLRequestChromeJob() {
void UnregisterURLRequestChromeJob() {
FilePath inspector_dir;
if (PathService::Get(chrome::DIR_INSPECTOR, &inspector_dir)) {
- Singleton<ChromeURLDataManager>()->RemoveFileSource(
+ ChromeURLDataManager::GetInstance()->RemoveFileSource(
chrome::kChromeUIDevToolsHost);
}
}
@@ -158,8 +158,8 @@ bool ChromeURLDataManager::URLToFilePath(const GURL& url,
URLToRequest(stripped_url, &source_name, &relative_path);
FileSourceMap::const_iterator i(
- Singleton<ChromeURLDataManager>()->file_sources_.find(source_name));
- if (i == Singleton<ChromeURLDataManager>()->file_sources_.end())
+ ChromeURLDataManager::GetInstance()->file_sources_.find(source_name));
+ if (i == ChromeURLDataManager::GetInstance()->file_sources_.end())
return false;
// Check that |relative_path| is not an absolute path (otherwise AppendASCII()
@@ -178,6 +178,11 @@ ChromeURLDataManager::ChromeURLDataManager() : next_request_id_(0) { }
ChromeURLDataManager::~ChromeURLDataManager() { }
+// static
+ChromeURLDataManager* ChromeURLDataManager::GetInstance() {
+ return Singleton<ChromeURLDataManager>::get();
+}
+
void ChromeURLDataManager::AddDataSource(scoped_refptr<DataSource> source) {
// TODO(jackson): A new data source with same name should not clobber the
// existing one.
@@ -287,7 +292,7 @@ void ChromeURLDataManager::DataSource::SendResponse(
RefCountedMemory* bytes) {
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
- NewRunnableMethod(Singleton<ChromeURLDataManager>::get(),
+ NewRunnableMethod(ChromeURLDataManager::GetInstance(),
&ChromeURLDataManager::DataAvailable,
request_id, scoped_refptr<RefCountedMemory>(bytes)));
}
@@ -347,7 +352,7 @@ URLRequestChromeJob::URLRequestChromeJob(net::URLRequest* request)
}
URLRequestChromeJob::~URLRequestChromeJob() {
- CHECK(!Singleton<ChromeURLDataManager>()->HasPendingJob(this));
+ CHECK(!ChromeURLDataManager::GetInstance()->HasPendingJob(this));
}
void URLRequestChromeJob::Start() {
@@ -358,7 +363,7 @@ void URLRequestChromeJob::Start() {
}
void URLRequestChromeJob::Kill() {
- Singleton<ChromeURLDataManager>()->RemoveRequest(this);
+ ChromeURLDataManager::GetInstance()->RemoveRequest(this);
}
bool URLRequestChromeJob::GetMimeType(std::string* mime_type) const {
@@ -418,7 +423,8 @@ void URLRequestChromeJob::StartAsync() {
if (!request_)
return;
- if (Singleton<ChromeURLDataManager>()->StartRequest(request_->url(), this)) {
+ if (ChromeURLDataManager::GetInstance()->StartRequest(request_->url(),
+ this)) {
NotifyHeadersComplete();
} else {
NotifyStartError(URLRequestStatus(URLRequestStatus::FAILED,
« no previous file with comments | « chrome/browser/dom_ui/chrome_url_data_manager.h ('k') | chrome/browser/dom_ui/conflicts_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698