Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4429)

Unified Diff: chrome/browser/cross_site_request_manager.h

Issue 5519016: Add a new GetInstance() method for singleton classes used in chrome/browser files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/crash_handler_host_linux_stub.cc ('k') | chrome/browser/cross_site_request_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cross_site_request_manager.h
diff --git a/chrome/browser/cross_site_request_manager.h b/chrome/browser/cross_site_request_manager.h
index 84d07e952ba5f566bf89273f865d78999d3b74a0..6c90b24c5937d7b957f7522e4d68d3b62e604056 100644
--- a/chrome/browser/cross_site_request_manager.h
+++ b/chrome/browser/cross_site_request_manager.h
@@ -11,7 +11,8 @@
#include "base/basictypes.h"
#include "base/lock.h"
-#include "base/singleton.h"
+
+template <typename T> struct DefaultSingletonTraits;
// CrossSiteRequestManager is used to handle bookkeeping for cross-site
// requests and responses between the UI and IO threads. Such requests involve
@@ -22,6 +23,9 @@
//
class CrossSiteRequestManager {
public:
+ // Returns the singleton instance.
+ static CrossSiteRequestManager* GetInstance();
+
// Returns whether the RenderViewHost specified by the given IDs currently
// has a pending cross-site request. If so, we will have to delay the
// response until the previous RenderViewHost runs its onunload handler.
@@ -38,8 +42,6 @@ class CrossSiteRequestManager {
friend struct DefaultSingletonTraits<CrossSiteRequestManager>;
typedef std::set<std::pair<int, int> > RenderViewSet;
- // Obtain an instance of CrossSiteRequestManager via
- // Singleton<CrossSiteRequestManager>().
CrossSiteRequestManager();
~CrossSiteRequestManager();
« no previous file with comments | « chrome/browser/crash_handler_host_linux_stub.cc ('k') | chrome/browser/cross_site_request_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698