chrome/test/live_sync/live_sync_test.cc - Issue 5519015: Explicitly whitelist the test server port.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/live_sync/live_sync_test.cc

Issue 5519015: Explicitly whitelist the test server port. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add helper class for whitelisting. Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/live_sync/live_sync_test.cc

diff --git a/chrome/test/live_sync/live_sync_test.cc b/chrome/test/live_sync/live_sync_test.cc

index 6adba5c26ca466947096d45d59b40ce047a64bee..675604c5b246690c81e3c741a8266f4418c53a8d 100644

--- a/chrome/test/live_sync/live_sync_test.cc

+++ b/chrome/test/live_sync/live_sync_test.cc

@@ -335,6 +335,7 @@ bool LiveSyncTest::SetUpLocalPythonTestServer() {

net::HostPortPair xmpp_host_port_pair(sync_server_.host_port_pair());

xmpp_host_port_pair.set_port(xmpp_port);

+ xmpp_port_.reset(new ScopedPortException(xmpp_port));

if (!cl->HasSwitch(switches::kSyncNotificationHost)) {

cl->AppendSwitchASCII(switches::kSyncNotificationHost,

@@ -379,6 +380,7 @@ bool LiveSyncTest::TearDownLocalPythonTestServer() {

LOG(ERROR) << "Could not stop local python test server.";

return false;

}

+ xmpp_port_.reset();

return true;

}