Explicitly whitelist the test server port.

net/test/test_server.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/test_server.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 141 matching lines @@
     return false;
 
   if (!LaunchPython(testserver_path))
     return false;
 
   if (!WaitToStart()) {
     Stop();
     return false;
   }
 
+  // TODO(akalin): Automaticall whitelist all ports openened by the test server.

[cbentzel, 2010/12/09 14:25:13]

This TODO isn't needed anymore. 

+  allowed_port_.reset(new ScopedPortException(host_port_pair_.port()));
+
   started_ = true;
   return true;
 }
 
 bool TestServer::Stop() {
   if (!process_handle_)
     return true;
 
   started_ = false;
 
   // First check if the process has already terminated.
   bool ret = base::WaitForSingleProcess(process_handle_, 0);
   if (!ret)
     ret = base::KillProcess(process_handle_, 1, true);
 
   if (ret) {
     base::CloseProcessHandle(process_handle_);
     process_handle_ = base::kNullProcessHandle;
   } else {
     VLOG(1) << "Kill failed?";
   }
 
+  allowed_port_.reset();
+
   return ret;
 }
 
 const HostPortPair& TestServer::host_port_pair() const {
   DCHECK(started_);
   return host_port_pair_;
 }
 
 const DictionaryValue& TestServer::server_data() const {
   DCHECK(started_);
@@ skipping 210 matching lines @@
   }
   if ((port <= 0) || (port > kuint16max)) {
     LOG(ERROR) << "Invalid port value: " << port;
     return false;
   }
   host_port_pair_.set_port(port);
   return true;
 }
 
 }  // namespace net