Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 5519008: Create a cros directory under client, and start moving things into it. (Closed)

Created:
10 years ago by ericli
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org
Visibility:
Public.

Description

Create a cros directory under client, and start moving things into it. The first step only includes chromeos_constants.py. But you get the idea how the others will look like. Change-Id: I0a601a53e4d9a43f06e9f9f67429ac780f2562d0 BUG=7236 TEST=bvt test I dont worry too much about occasional break ups caused by this, since I will continues working on this refactoring and this is just the beginning. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4b1222e

Patch Set 1 #

Patch Set 2 : patch #

Patch Set 3 : patch #

Patch Set 4 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -21 lines) Patch
M client/bin/site_cryptohome.py View 1 chunk +2 lines, -2 lines 0 comments Download
M client/bin/site_log_reader.py View 1 1 chunk +1 line, -1 line 0 comments Download
M client/bin/site_logging.py View 1 1 chunk +1 line, -1 line 0 comments Download
M client/bin/site_login.py View 1 chunk +2 lines, -1 line 0 comments Download
M client/bin/site_sysinfo.py View 1 chunk +1 line, -1 line 0 comments Download
M client/bin/site_ui_test.py View 1 chunk +2 lines, -1 line 0 comments Download
M client/common_lib/cros/autoupdater.py View 1 chunk +1 line, -1 line 0 comments Download
M client/common_lib/site_auth_server.py View 1 chunk +2 lines, -1 line 0 comments Download
M client/common_lib/site_auth_server_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A client/cros/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A client/cros/common.py View 1 chunk +8 lines, -0 lines 0 comments Download
A + client/cros/constants.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M client/site_tests/logging_CrashServices/logging_CrashServices.py View 1 chunk +2 lines, -1 line 0 comments Download
M client/site_tests/login_Backdoor/login_Backdoor.py View 1 chunk +1 line, -1 line 0 comments Download
M client/site_tests/login_BadAuthentication/login_BadAuthentication.py View 1 chunk +1 line, -1 line 0 comments Download
M client/site_tests/login_ChromeProfileSanitary/login_ChromeProfileSanitary.py View 1 chunk +2 lines, -1 line 0 comments Download
M client/site_tests/login_CryptohomeIncognitoMounted/login_CryptohomeIncognitoMounted.py View 1 chunk +1 line, -1 line 0 comments Download
M client/site_tests/login_CryptohomeIncognitoUnmounted/login_CryptohomeIncognitoUnmounted.py View 1 chunk +1 line, -1 line 0 comments Download
M client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py View 1 chunk +1 line, -2 lines 0 comments Download
M client/site_tests/login_CryptohomeUnmounted/login_CryptohomeUnmounted.py View 1 chunk +0 lines, -1 line 0 comments Download
M client/site_tests/login_DBusCalls/login_DBusCalls.py View 1 chunk +2 lines, -1 line 0 comments Download
M client/site_tests/login_SecondFactor/login_SecondFactor.py View 1 chunk +1 line, -1 line 0 comments Download
M client/site_tests/security_RestartJob/security_RestartJob.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ericli
10 years ago (2010-12-06 19:26:02 UTC) #1
truty
I'm not the primary reviewer but I reviewed this anyway. I'd point out that Eric ...
10 years ago (2010-12-06 20:52:56 UTC) #2
kmixter1
Didn't look at every file, but assuming that the only change is moving chromeos_constants to ...
10 years ago (2010-12-06 23:20:07 UTC) #3
ericli
10 years ago (2010-12-06 23:23:20 UTC) #4
Yes, I will landing a bunch of changes and every change will only move a
small set of files.

Thanks, I will push shortly.

On Mon, Dec 6, 2010 at 3:20 PM, <kmixter@chromium.org> wrote:

> Didn't look at every file, but assuming that the only change is moving
> chromeos_constants to cros/constants.py LGTM.  Assuming also that you'll be
> moving more files over there in short order so that people adding new
> chromeos-specific modules know exactly where they should go (cros subdir).
>
>
> http://codereview.chromium.org/5519008/
>



-- 
Eric Li
李咏竹
Google Kirkland

Powered by Google App Engine
This is Rietveld 408576698