Issue 5519001: DOMUI prefs: Re-order sections in the sidebar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5519001: DOMUI prefs: Re-order sections in the sidebar (Closed)

Created:
10 years ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI prefs: Re-order sections in the sidebar Per UI mocks. BUG=63814 TEST=Basic prefs should come first on all platforms Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67938

Patch Set 2 : Change default on Chrome OS #

Total comments: 2

Patch Set 3 : Move includes #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -18 lines)			Patch
	M	chrome/browser/resources/options.html	View	1 2	4 chunks	+13 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

csilv

http://codereview.chromium.org/5519001/diff/2001/chrome/browser/resources/options.html File chrome/browser/resources/options.html (right): http://codereview.chromium.org/5519001/diff/2001/chrome/browser/resources/options.html#newcode335 chrome/browser/resources/options.html:335: <include src="options/browser_options.html"> Please move include for browser_options.html and personal_options.html ...

10 years ago (2010-12-02 00:09:59 UTC) #2

stuartmorgan

10 years ago (2010-12-02 00:29:14 UTC) #3

LGTM