Chromium Code Reviews Chromium Code Reviews
Issue 5518006:
DOMUI Prefs: Add a close button to sub-pages (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 <!DOCTYPE HTML> | 1 <!DOCTYPE HTML> |
| 2 <html | 2 <html |
| 3 i18n-values="dir:textdirection; | 3 i18n-values="dir:textdirection; |
| 4 enable-cloud-print-proxy:enable-cloud-print-proxy" | 4 enable-cloud-print-proxy:enable-cloud-print-proxy" |
| 5 id="t"> | 5 id="t"> |
| 6 <head> | 6 <head> |
| 7 <meta charset="utf-8"> | 7 <meta charset="utf-8"> |
| 8 <title i18n-content="title"></title> | 8 <title i18n-content="title"></title> |
| 9 | 9 |
| 10 <link rel="icon" href="../../app/theme/settings_favicon.png"> | 10 <link rel="icon" href="../../app/theme/settings_favicon.png"> |
| (...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 330 <include src="options/personal_options.html"> | 330 <include src="options/personal_options.html"> |
| 331 <if expr="pp_ifdef('chromeos')"> | 331 <if expr="pp_ifdef('chromeos')"> |
| 332 <include src="options/chromeos_system_options.html"> | 332 <include src="options/chromeos_system_options.html"> |
| 333 <include src="options/chromeos_internet_options.html"> | 333 <include src="options/chromeos_internet_options.html"> |
| 334 <include src="options/chromeos_accounts_options.html"> | 334 <include src="options/chromeos_accounts_options.html"> |
| 335 </if> | 335 </if> |
| 336 <include src="options/advanced_options.html"> | 336 <include src="options/advanced_options.html"> |
| 337 <!-- End main pages --> | 337 <!-- End main pages --> |
| 338 <div id="subpage-sheet-container" class="hidden"> | 338 <div id="subpage-sheet-container" class="hidden"> |
| 339 <div id="subpage-sheet"> | 339 <div id="subpage-sheet"> |
| 340 <div class="close-subpage" | |
|
arv (Not doing code reviews)
2010/12/06 20:00:32
This should have been a button element.
| |
| 341 onclick="OptionsPage.closeSubPage();"></div> | |
| 340 <if expr="pp_ifdef('chromeos')"> | 342 <if expr="pp_ifdef('chromeos')"> |
| 341 <include src="options/about_page.html"> | 343 <include src="options/about_page.html"> |
| 342 <include src="options/chromeos_language_options.html"> | 344 <include src="options/chromeos_language_options.html"> |
| 343 <include src="options/chromeos_language_chewing_options.html"> | 345 <include src="options/chromeos_language_chewing_options.html"> |
| 344 <include src="options/chromeos_language_hangul_options.html"> | 346 <include src="options/chromeos_language_hangul_options.html"> |
| 345 <include src="options/chromeos_language_mozc_options.html"> | 347 <include src="options/chromeos_language_mozc_options.html"> |
| 346 <include src="options/chromeos_language_pinyin_options.html"> | 348 <include src="options/chromeos_language_pinyin_options.html"> |
| 347 <include src="options/chromeos_proxy.html"> | 349 <include src="options/chromeos_proxy.html"> |
| 348 </if> | 350 </if> |
| 349 <if expr="not pp_ifdef('win32') and not pp_ifdef('darwin')"> | 351 <if expr="not pp_ifdef('win32') and not pp_ifdef('darwin')"> |
| (...skipping 22 matching lines...) Expand all Loading... | |
| 372 cr.ui.decorate('input[pref][type=text]', options.PrefTextField); | 374 cr.ui.decorate('input[pref][type=text]', options.PrefTextField); |
| 373 cr.ui.decorate('input[pref][type=url]', options.PrefTextField); | 375 cr.ui.decorate('input[pref][type=url]', options.PrefTextField); |
| 374 cr.ui.decorate('#contentSettingsPage input[type=radio]', | 376 cr.ui.decorate('#contentSettingsPage input[type=radio]', |
| 375 options.ContentSettingsRadio); | 377 options.ContentSettingsRadio); |
| 376 cr.ui.decorate('#fontSettingsMinimumSizeSelector', | 378 cr.ui.decorate('#fontSettingsMinimumSizeSelector', |
| 377 options.MinimumFontSizeSelect); | 379 options.MinimumFontSizeSelect); |
| 378 console.log('in bottom script'); | 380 console.log('in bottom script'); |
| 379 </script> | 381 </script> |
| 380 </body> | 382 </body> |
| 381 </html> | 383 </html> |
| OLD | NEW |
