Issue 5518006: DOMUI Prefs: Add a close button to sub-pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5518006: DOMUI Prefs: Add a close button to sub-pages (Closed)

Created:
10 years ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
csilv, arv (Not doing code reviews)

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI Prefs: Add a close button to sub-pages BUG=65203 TEST=Open a DOMUI pref subpage; there should be a close button in the upper-right. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68372

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -8 lines)			Patch
	M	chrome/browser/resources/options.html	View		1 chunk	+2 lines, -0 lines	1 comment	Download
	M	chrome/browser/resources/options/options_page.css	View		1 chunk	+18 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

http://codereview.chromium.org/5518006/diff/1/chrome/browser/resources/options.html File chrome/browser/resources/options.html (right): http://codereview.chromium.org/5518006/diff/1/chrome/browser/resources/options.html#newcode340 chrome/browser/resources/options.html:340: <div class="close-subpage" This should have been a button element.

10 years ago (2010-12-06 20:00:32 UTC) #3

stuartmorgan

10 years ago (2010-12-06 21:07:55 UTC) #4

On 2010/12/06 20:00:32, arv wrote:
> This should have been a button element.

Good point; I'll put together another CL to switch it.

Expand Messages | Collapse Messages