AU: Split applied update verification into a separate step.

AU: Split applied update verification into a separate step.

Use instances of FilesystemCopierAction to do applied update verification. This
speeds it up slightly because asynchronous reads happen in parallel with hash
calculation but, more importantly, makes update_engine be responsive to D-Bus
during that step.

BUG=9140
TEST=unit tests, tested on device

Change-Id: I3ec9445de5e8258a63433a61f1a476aef4434f6c

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3aefa86

[adlr, 2010-12-07 02:22:20]

LGTM if you address the feedback

http://codereview.chromium.org/5516009/diff/4001/delta_performer.cc
File delta_performer.cc (right):

http://codereview.chromium.org/5516009/diff/4001/delta_performer.cc#newcode605
delta_performer.cc:605: kernel_hash->swap(new_kernel_hash);
easier to do kernel_hash->assign()?

http://codereview.chromium.org/5516009/diff/4001/delta_performer.h
File delta_performer.h (right):

http://codereview.chromium.org/5516009/diff/4001/delta_performer.h#newcode69
delta_performer.h:69: // been parsed (e.g., after closing the stream).
explain return value?

http://codereview.chromium.org/5516009/diff/4001/delta_performer.h#newcode101
delta_performer.h:101: void set_current_kernel_hash(const std::vector<char>
hash) {
s/>/>&/

http://codereview.chromium.org/5516009/diff/4001/delta_performer.h#newcode105
delta_performer.h:105: void set_current_rootfs_hash(const std::vector<char>
hash) {
s/>/>&/

[petkov, 2010-12-07 17:34:02]

Addressed and responded to comments. PTAL. Thanks!

http://codereview.chromium.org/5516009/diff/4001/delta_performer.cc
File delta_performer.cc (right):

http://codereview.chromium.org/5516009/diff/4001/delta_performer.cc#newcode605
delta_performer.cc:605: kernel_hash->swap(new_kernel_hash);
On 2010/12/07 02:22:20, adlr wrote:
> easier to do kernel_hash->assign()?

I think swap would be more efficient than assign (or operator =), not that it
matters much, because it would avoid copying the data. So left it as swap.

http://codereview.chromium.org/5516009/diff/4001/delta_performer.h
File delta_performer.h (right):

http://codereview.chromium.org/5516009/diff/4001/delta_performer.h#newcode69
delta_performer.h:69: // been parsed (e.g., after closing the stream).
On 2010/12/07 02:22:20, adlr wrote:
> explain return value?

Done.

http://codereview.chromium.org/5516009/diff/4001/delta_performer.h#newcode101
delta_performer.h:101: void set_current_kernel_hash(const std::vector<char>
hash) {
On 2010/12/07 02:22:20, adlr wrote:
> s/>/>&/

Duh.. Done.

http://codereview.chromium.org/5516009/diff/4001/delta_performer.h#newcode105
delta_performer.h:105: void set_current_rootfs_hash(const std::vector<char>
hash) {
On 2010/12/07 02:22:20, adlr wrote:
> s/>/>&/

Done.

[adlr, 2010-12-07 22:36:23]

LGTM