Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2944)

Unified Diff: chrome/browser/renderer_host/resource_message_filter.cc

Issue 5516004: Clean up PluginGroup and related code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/resource_message_filter.cc
diff --git a/chrome/browser/renderer_host/resource_message_filter.cc b/chrome/browser/renderer_host/resource_message_filter.cc
index f82e398cc1b89dc302250848fd4e70443c1003f1..663a48e0fa52cb70d53ae92464087f20b2bcfbeb 100644
--- a/chrome/browser/renderer_host/resource_message_filter.cc
+++ b/chrome/browser/renderer_host/resource_message_filter.cc
@@ -859,21 +859,20 @@ void ResourceMessageFilter::OnGotPluginInfo(bool found,
const GURL& policy_url,
IPC::Message* reply_msg) {
ContentSetting setting = CONTENT_SETTING_DEFAULT;
+ WebPluginInfo info_copy = info;
if (found) {
- WebPluginInfo info_copy = info;
info_copy.enabled = info_copy.enabled &&
plugin_service_->PrivatePluginAllowedForURL(info_copy.path, policy_url);
HostContentSettingsMap* map = profile_->GetHostContentSettingsMap();
- scoped_ptr<PluginGroup> group(
- PluginGroup::CopyOrCreatePluginGroup(info_copy));
- std::string resource = group->identifier();
+ std::string resource =
+ NPAPI::PluginList::Singleton()->GetPluginGroupIdentifier(info_copy);
setting = map->GetContentSetting(policy_url,
CONTENT_SETTINGS_TYPE_PLUGINS,
resource);
}
ViewHostMsg_GetPluginInfo::WriteReplyParams(
- reply_msg, found, info, setting, actual_mime_type);
+ reply_msg, found, info_copy, setting, actual_mime_type);
Send(reply_msg);
}

Powered by Google App Engine
This is Rietveld 408576698