Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: chrome/browser/ui/views/content_setting_bubble_contents.cc

Issue 5516004: Clean up PluginGroup and related code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/content_setting_bubble_contents.cc
diff --git a/chrome/browser/ui/views/content_setting_bubble_contents.cc b/chrome/browser/ui/views/content_setting_bubble_contents.cc
index ff4561cbe822d9d0d8efc54216c52b931936a363..4263077b99a3b89aed72d7ab31321a1311032971 100644
--- a/chrome/browser/ui/views/content_setting_bubble_contents.cc
+++ b/chrome/browser/ui/views/content_setting_bubble_contents.cc
@@ -230,10 +230,9 @@ void ContentSettingBubbleContents::InitControlLayout() {
for (std::set<std::string>::const_iterator it = plugins.begin();
it != plugins.end(); ++it) {
std::wstring name;
- NPAPI::PluginList::PluginMap groups;
- NPAPI::PluginList::Singleton()->GetPluginGroups(false, &groups);
- if (groups.find(*it) != groups.end())
- name = UTF16ToWide(groups[*it]->GetGroupName());
+ NPAPI::PluginList::PluginGroup group;
+ if (NPAPI::PluginList::Singleton()->GetPluginGroup(false, *it, &groups))
Bernhard Bauer 2010/12/03 16:13:28 There's something wrong here. I guess that's why i
Jakob Kummerow 2010/12/06 18:21:12 Done. This should of course match the code in cont
+ name = UTF16ToWide(group.GetGroupName());
else
name = UTF8ToWide(*it);
layout->StartRow(0, single_column_set_id);

Powered by Google App Engine
This is Rietveld 408576698