Clean up PluginGroup and related code.

chrome/browser/ui/cocoa/table_model_array_controller_unittest.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/table_model_array_controller.h"
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/mock_plugin_exceptions_table_model.h"
 #include "chrome/browser/ui/cocoa/browser_test_helper.h"
 #import "chrome/browser/ui/cocoa/cocoa_test_helper.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/testing_profile.h"
 #include "grit/generated_resources.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/gtest_mac.h"
 #include "webkit/glue/plugins/plugin_list.h"
 #include "webkit/glue/plugins/webplugininfo.h"
 
-namespace {
-
 class TableModelArrayControllerTest : public CocoaTest {
  public:
   TableModelArrayControllerTest()
       : command_line_(CommandLine::ForCurrentProcess(),
                       *CommandLine::ForCurrentProcess()) {}
 
   virtual void SetUp() {
     CocoaTest::SetUp();
 
     CommandLine::ForCurrentProcess()->AppendSwitch(
@@ skipping 12 matching lines @@
                            CONTENT_SETTINGS_TYPE_PLUGINS,
                            "b-bar",
                            CONTENT_SETTING_BLOCK);
     map->SetContentSetting(example_com,
                            CONTENT_SETTINGS_TYPE_PLUGINS,
                            "b-bar",
                            CONTENT_SETTING_ALLOW);
 
     model_.reset(new MockPluginExceptionsTableModel(map, NULL));
 
-    NPAPI::PluginList::PluginMap plugins;
+    std::vector<PluginGroup> plugins;
     WebPluginInfo foo_plugin;
     foo_plugin.path = FilePath(FILE_PATH_LITERAL("a-foo"));
     foo_plugin.name = ASCIIToUTF16("FooPlugin");
     foo_plugin.enabled = true;
-    PluginGroup* foo_group = PluginGroup::FromWebPluginInfo(foo_plugin);
-    plugins[foo_group->identifier()] = linked_ptr<PluginGroup>(foo_group);
+    scoped_ptr<PluginGroup> foo_group(
+        PluginGroup::FromWebPluginInfo(foo_plugin));
+    plugins.push_back(*foo_group);
     WebPluginInfo bar_plugin;
     bar_plugin.path = FilePath(FILE_PATH_LITERAL("b-bar"));
     bar_plugin.name = ASCIIToUTF16("BarPlugin");
     bar_plugin.enabled = true;
-    PluginGroup* bar_group = PluginGroup::FromWebPluginInfo(bar_plugin);
-    plugins[bar_group->identifier()] = linked_ptr<PluginGroup>(bar_group);
+    scoped_ptr<PluginGroup> bar_group(
+        PluginGroup::FromWebPluginInfo(bar_plugin));
+    plugins.push_back(*bar_group);
     WebPluginInfo blurp_plugin;
     blurp_plugin.path = FilePath(FILE_PATH_LITERAL("c-blurp"));
     blurp_plugin.name = ASCIIToUTF16("BlurpPlugin");
     blurp_plugin.enabled = true;
-    PluginGroup* blurp_group = PluginGroup::FromWebPluginInfo(blurp_plugin);
-    plugins[blurp_group->identifier()] = linked_ptr<PluginGroup>(blurp_group);
+    scoped_ptr<PluginGroup> blurp_group(
+        PluginGroup::FromWebPluginInfo(blurp_plugin));
+    plugins.push_back(*blurp_group);
 
     model_->set_plugins(plugins);
     model_->LoadSettings();
 
     id content = [NSMutableArray array];
     controller_.reset(
         [[TableModelArrayController alloc] initWithContent:content]);
     NSDictionary* columns = [NSDictionary dictionaryWithObjectsAndKeys:
         [NSNumber numberWithInt:IDS_EXCEPTIONS_HOSTNAME_HEADER], @"title",
         [NSNumber numberWithInt:IDS_EXCEPTIONS_ACTION_HEADER], @"action",
@@ skipping 77 matching lines @@
   [controller setSelectionIndexes:indexes];
   [controller remove:nil];
   titles = [[controller arrangedObjects] valueForKey:@"title"];
   EXPECT_NSEQ(@"(\n"
               @"    BarPlugin,\n"
               @"    \"[*.]example.com\",\n"
               @"    \"[*.]moose.org\"\n"
               @")",
               [titles description]);
 }
-
-}  // namespace