chrome/browser/mock_plugin_exceptions_table_model.cc - Issue 5516004: Clean up PluginGroup and related code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/mock_plugin_exceptions_table_model.cc

Issue 5516004: Clean up PluginGroup and related code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/mock_plugin_exceptions_table_model.h"	5 #include "chrome/browser/mock_plugin_exceptions_table_model.h"

6	6

7 void MockPluginExceptionsTableModel::set_plugins(	7 void MockPluginExceptionsTableModel::set_plugins(

8 const NPAPI::PluginList::PluginMap& plugins) {	8 const std::vector<PluginGroup>& plugins) {

9 plugins_ = plugins;	9 for (size_t i = 0; i < plugins.size(); ++i)

	10 plugins_.push_back(plugins[i]);
	Bernhard Bauer 2010/12/03 16:13:28 I think you could just assign the vector. I think you could just assign the vector. Jakob Kummerow 2010/12/06 18:21:12 Done. Show quoted text On 2010/12/03 16:13:28, Bernhard Bauer wrote: > I think you could just assign the vector. Done.
10 }	11 }

11	12

12 void MockPluginExceptionsTableModel::GetPlugins(	13 std::vector<PluginGroup> MockPluginExceptionsTableModel::GetPlugins() {

13 NPAPI::PluginList::PluginMap* plugins) {	14 return plugins_;

14 *plugins = plugins_;

15 }	15 }

OLD	NEW