Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: webkit/glue/media/buffered_data_source.cc

Issue 5515008: Using WebFrame::createAssociatedURLLoader() instead of WebFrame::dispatchWillSendRequest(...) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added a setTargetType for the requests Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/glue/media/simple_data_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/media/buffered_data_source.cc
diff --git a/webkit/glue/media/buffered_data_source.cc b/webkit/glue/media/buffered_data_source.cc
index 2e91bcc6374e3d5e70fff38aced4c60bbd317c2b..e3250b68b3e95073681dee082468686d34c10b9c 100644
--- a/webkit/glue/media/buffered_data_source.cc
+++ b/webkit/glue/media/buffered_data_source.cc
@@ -144,17 +144,16 @@ void BufferedResourceLoader::Start(net::CompletionCallback* start_callback,
// Prepare the request.
WebURLRequest request(url_);
+ request.setTargetType(WebURLRequest::TargetIsMedia);
request.setHTTPHeaderField(WebString::fromUTF8("Range"),
WebString::fromUTF8(GenerateHeaders(
first_byte_position_,
last_byte_position_)));
frame->setReferrerForRequest(request, WebKit::WebURL());
- // TODO(annacc): we should be using createAssociatedURLLoader() instead?
- frame->dispatchWillSendRequest(request);
// This flag is for unittests as we don't want to reset |url_loader|
if (!keep_test_loader_)
- url_loader_.reset(WebKit::webKitClient()->createURLLoader());
+ url_loader_.reset(frame->createAssociatedURLLoader());
// Start the resource loading.
url_loader_->loadAsynchronously(request, this);
« no previous file with comments | « no previous file | webkit/glue/media/simple_data_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698