Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 5513009: Moving chromeos_version.sh to chromiumos_overlay. (Closed)

Created:
10 years ago by djmm
Modified:
9 years, 7 months ago
Reviewers:
David McMahon, sosa, anush
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Moving chromeos_version.sh to chromiumos_overlay. BUG=chromium-os:9714 TEST= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=48db5d2

Patch Set 1 #

Patch Set 2 : crosversion #

Patch Set 3 : crosversion #

Patch Set 4 : crosversion #

Patch Set 5 : crosversion #

Total comments: 1

Patch Set 6 : crosversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -95 lines) Patch
M bin/cbuildbot.py View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M build_image View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D chromeos_version.sh View 1 chunk +0 lines, -93 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
djmm
The other change is coming shortly for chromiumos-overlay.
10 years ago (2010-12-07 01:03:09 UTC) #1
sosa
LGTM
10 years ago (2010-12-07 01:15:21 UTC) #2
David McMahon
PTAL. Updated build_image to reference the moved chromeos_version.sh.
10 years ago (2010-12-08 21:53:52 UTC) #3
anush
Could we use ${SRC_ROOT}/third_party/... instead? It is defined in common.sh already. Thanks On Wed, Dec ...
10 years ago (2010-12-08 23:19:41 UTC) #4
David McMahon
PTAL.
10 years ago (2010-12-08 23:23:22 UTC) #5
sosa
LGTM
10 years ago (2010-12-09 18:49:40 UTC) #6
David McMahon
PTAL
10 years ago (2010-12-14 23:25:09 UTC) #7
sosa
10 years ago (2010-12-14 23:30:34 UTC) #8
One correction.

O/w lgtm ... also you should prob make sure and do a last minute dbl-check diff
between chromeos_version.sh here and in the overlay so we don't miss any last
minute changes.

http://codereview.chromium.org/5513009/diff/16001/bin/cbuildbot.py
File bin/cbuildbot.py (right):

http://codereview.chromium.org/5513009/diff/16001/bin/cbuildbot.py#newcode290
bin/cbuildbot.py:290: cwd = os.path.join(buildroot, 'src', 'thirdparty',
'chromiumos-overlay',
third_party*

Powered by Google App Engine
This is Rietveld 408576698