Issue 5513002: Temporarily increase the safe-browsing bloom filter size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5513002: Temporarily increase the safe-browsing bloom filter size. (Closed)

Created:
10 years ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
lzheng

CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Temporarily increase the safe-browsing bloom filter size. The bloom filter seems to be hitting the max size sometimes, which is (apparently) driving up SB2.GetHash204 results. Increase the size a bit to see if that's really the problem. BUG=64995 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67975

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/safe_browsing/bloom_filter.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

I figure we can push this to the canary and monitor SB2.GetHash200/4 to see if ...

10 years ago (2010-12-02 00:36:53 UTC) #1

lzheng

10 years ago (2010-12-02 00:43:18 UTC) #2

LGTM
On 2010/12/02 00:36:53, shess wrote:
> I figure we can push this to the canary and monitor SB2.GetHash200/4 to see if
> it has a beneficial impact.

Expand Messages | Collapse Messages