Issue 551214: GTK: Make page and app menus shortcut control flow match windows more closely...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 551214: GTK: Make page and app menus shortcut control flow match windows more closely... (Closed)

Created:
10 years, 10 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
mattm

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GTK: Make page and app menus shortcut control flow match windows more closely. BUG=33471 TEST=alt+f, alt+e Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37725

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -28 lines)			Patch
M	chrome/browser/gtk/accelerators_gtk.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/browser_toolbar_gtk.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/browser_toolbar_gtk.cc	View	4 chunks	+8 lines, -18 lines	1 comment	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mattm

lgtm http://codereview.chromium.org/551214/diff/1/2 File chrome/browser/gtk/browser_toolbar_gtk.cc (right): http://codereview.chromium.org/551214/diff/1/2#newcode233 chrome/browser/gtk/browser_toolbar_gtk.cc:233: g_object_unref(accel_group); should accel_group be removed too?

10 years, 10 months ago (2010-01-30 01:11:04 UTC) #2

yes. thanks for catching that.

Expand Messages | Collapse Messages