Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5512009: Remove unneeded browser_process.h includes. (Closed)

Created:
10 years ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, ncarter (slow), nkostylev+cc_chromium.org, ben+cc_chromium.org, Raghu Simha, Erik does not do reviews, idana, jam, cbentzel+watch_chromium.org, kinuko, Aaron Boodman, pam+watch_chromium.org, tim (not reviewing), rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, native-client-reviews_googlegroups.com, brettw-cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove unneeded browser_process.h includes. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68323

Patch Set 1 #

Patch Set 2 : fix linux build #

Total comments: 13
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -124 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_list.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_node_data.cc View 1 chunk +8 lines, -4 lines 2 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils_unittest.cc View 2 chunks +4 lines, -2 lines 1 comment Download
M chrome/browser/browser_browsertest.cc View 2 chunks +1 line, -1 line 1 comment Download
M chrome/browser/browser_process.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_mock.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/mobile_setup_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/cookie_fetcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/cookie_fetcher_unittest.cc View 1 chunk +0 lines, -1 line 2 comments Download
M chrome/browser/chromeos/login/google_authenticator.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/image_downloader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/signed_settings_temp_storage.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/signed_settings_temp_storage_unittest.cc View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_downloader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_accessibility_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/debugger/debugger_remote_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_remote_service.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/chrome_url_data_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/options/about_page_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/options/advanced_options_handler.cc View 2 chunks +3 lines, -1 line 2 comments Download
M chrome/browser/dom_ui/options/personal_options_handler.cc View 2 chunks +2 lines, -1 line 2 comments Download
MM chrome/browser/dom_ui/shared_resources_data_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_util.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_metrics_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_rlz_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/file_system/file_system_dispatcher_host.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/gpu_process_host.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/gtk/dialogs_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/first_run_dialog.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/gtk/options/content_settings_window_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/options/fonts_page_gtk.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/gtk/options/passwords_exceptions_window_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/history_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/io_thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_broker_host_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_broker_service_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/prerender_interceptor.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/notifications/notification_object_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/policy/device_management_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/process_singleton_linux_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/async_resource_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/database_dispatcher_host.cc View 2 chunks +5 lines, -4 lines 1 comment Download
MM chrome/browser/renderer_host/pepper_file_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/x509_user_cert_resource_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_service.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/speech/speech_input_manager.cc View 3 chunks +7 lines, -5 lines 1 comment Download
M chrome/browser/sync/engine/syncapi.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/navigation_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/translate/options_menu_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_modal_dialogs/message_box_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/about_chrome_view.cc View 3 chunks +9 lines, -4 lines 1 comment Download
M chrome/browser/ui/views/constrained_window_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/external_protocol_dialog.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/options/content_page_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/options/content_settings_window_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/options/options_page_view.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/visitedlink/visitedlink_master.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/worker_host/worker_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/live_sync/live_sessions_sync_test.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
10 years ago (2010-12-04 04:19:35 UTC) #1
James Hawkins
http://codereview.chromium.org/5512009/diff/53002/chrome/browser/bookmarks/bookmark_node_data.cc File chrome/browser/bookmarks/bookmark_node_data.cc (right): http://codereview.chromium.org/5512009/diff/53002/chrome/browser/bookmarks/bookmark_node_data.cc#newcode19 chrome/browser/bookmarks/bookmark_node_data.cc:19: #if defined(OS_MACOSX) #ifdef includes are supposed to be in ...
10 years ago (2010-12-05 17:58:47 UTC) #2
Lei Zhang
http://codereview.chromium.org/5512009/diff/53002/chrome/browser/bookmarks/bookmark_node_data.cc File chrome/browser/bookmarks/bookmark_node_data.cc (right): http://codereview.chromium.org/5512009/diff/53002/chrome/browser/bookmarks/bookmark_node_data.cc#newcode19 chrome/browser/bookmarks/bookmark_node_data.cc:19: #if defined(OS_MACOSX) On 2010/12/05 17:58:47, James Hawkins wrote: > ...
10 years ago (2010-12-05 18:22:40 UTC) #3
James Hawkins
On 2010/12/05 18:22:40, Lei Zhang wrote: > http://codereview.chromium.org/5512009/diff/53002/chrome/browser/bookmarks/bookmark_node_data.cc > File chrome/browser/bookmarks/bookmark_node_data.cc (right): > > http://codereview.chromium.org/5512009/diff/53002/chrome/browser/bookmarks/bookmark_node_data.cc#newcode19 ...
10 years ago (2010-12-05 18:32:33 UTC) #4
James Hawkins
On 2010/12/05 18:32:33, James Hawkins wrote: > On 2010/12/05 18:22:40, Lei Zhang wrote: > > ...
10 years ago (2010-12-05 18:33:28 UTC) #5
Lei Zhang
10 years ago (2010-12-05 20:14:49 UTC) #6 
http://codereview.chromium.org/5512009/diff/53002/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/cookie_fetcher_unittest.cc (right):

http://codereview.chromium.org/5512009/diff/53002/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/cookie_fetcher_unittest.cc:7: #include
"chrome/browser/browser_thread.h"
On 2010/12/05 17:58:47, James Hawkins wrote:
> Blank line separating c/c++ includes from chrome includes.

Done.

http://codereview.chromium.org/5512009/diff/53002/chrome/browser/dom_ui/optio...
File chrome/browser/dom_ui/options/personal_options_handler.cc (right):

http://codereview.chromium.org/5512009/diff/53002/chrome/browser/dom_ui/optio...
chrome/browser/dom_ui/options/personal_options_handler.cc:20: #endif
On 2010/12/05 17:58:47, James Hawkins wrote:
> #endif  // defined(OS_CHROMEOS)

Done.

Powered by Google App Engine
This is Rietveld 408576698