Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 5512004: Improve code generated for AllocInNewSpace (Closed)

Created:
10 years ago by Rodolph Perfetta
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Improve code generated for AllocInNewSpace BUG=none TEST=none

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -51 lines) Patch
M src/arm/macro-assembler-arm.cc View 3 chunks +80 lines, -51 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Rodolph Perfetta
10 years ago (2010-12-02 16:46:08 UTC) #1
Mads Ager (chromium)
Erik, could you have a look?
10 years ago (2010-12-03 06:42:29 UTC) #2
Erik Corry
10 years ago (2010-12-06 10:00:13 UTC) #3
I changed a uint32_t to intptr_t because it worked better as a signed integer
and because the intent was to have an integer big enough for a pointer.

Committed as 5917.  Thanks.

Powered by Google App Engine
This is Rietveld 408576698