Issue 5512001: Cloned from issue http://codereview.chromium.org/5277004/ by rogerta@chromium...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5512001: Cloned from issue http://codereview.chromium.org/5277004/ by rogerta@chromium... (Closed)

Created:
10 years ago by Cindy Lau

Modified:
9 years, 7 months ago

Reviewers:
Eric Dingle, Jói

CC:
chromium-reviews, ceee-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add implementation of tabs.getCurrent() API, and correct implementation of windows.getCurrent(), to Firefox's CEEE. Cloned from issue http://codereview.chromium.org/5277004/ by rogerta@chromium.org. BUG=64979 TEST=see integration tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67961

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -9 lines)			Patch
M	ceee/firefox/content/cf.js	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	ceee/firefox/content/overlay.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ceee/firefox/content/tab_api.js	View	2 chunks	+19 lines, -0 lines	0 comments	Download
M	ceee/firefox/content/window_api.js	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	ceee/firefox/modules/global.js	View	2 chunks	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jói

LGTM, but before checking in, please modify the change description to start with the original ...

10 years ago (2010-12-02 01:58:13 UTC) #3

Cindy Lau

10 years ago (2010-12-02 02:00:08 UTC) #4

On 2010/12/02 01:58:13, Jói wrote:
> LGTM, but before checking in, please modify the change description to
> start with the original description, put "cloned at / submitting for"
> at the end, so that a quick scan of the SVN logs shows what the change
> is actually about.
> 
> 
> On Wed, Dec 1, 2010 at 6:42 PM,  <mailto:ericdingle@chromium.org> wrote:
> > LGTM
> >
> > http://codereview.chromium.org/5512001/
> >

Done.  Thanks for the reviews!

Expand Messages | Collapse Messages