Issue 551196: Very temporary fix for theme bug where adding more resources invalidates the ThemePack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 551196: Very temporary fix for theme bug where adding more resources invalidates the ThemePack. (Closed)

Created:
10 years, 10 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Very temporary fix for theme bug where adding more resources invalidates the ThemePack so we can release a dev channel. Move new resources to the end so they don't modify current IDR ids that are now baked into BrowserThemePacks. BUG=33416 TEST=Themes from previous dev channel work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37458

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/app/theme/theme_resources.grd	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

10 years, 10 months ago (2010-01-28 23:01:26 UTC) #2

LGTM.  Can you somehow explain to people that anything added to this file should
go at the END for the next couple of weeks?

Expand Messages | Collapse Messages