Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 551189: Propagate receiver from initial call site to code generator. (Closed)

Created:
10 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund, fschneider
CC:
v8-dev
Visibility:
Public.

Description

Propagate receiver from initial call site to code generator. When doing lazy compilation of methods, allow the code generator to know the (initial) receiver at the (initial) call site. Committed: http://code.google.com/p/v8/source/detail?r=3739

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -64 lines) Patch
M src/accessors.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M src/builtins.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler.h View 1 chunk +3 lines, -1 line 1 comment Download
M src/compiler.cc View 6 chunks +19 lines, -7 lines 0 comments Download
M src/debug.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/debug.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/fast-codegen.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/fast-codegen.cc View 2 chunks +18 lines, -1 line 0 comments Download
M src/handles.h View 1 chunk +11 lines, -4 lines 0 comments Download
M src/handles.cc View 1 chunk +26 lines, -8 lines 0 comments Download
M src/ic.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 6 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
10 years, 10 months ago (2010-01-28 14:50:48 UTC) #1
Kasper Lund
http://codereview.chromium.org/551189/diff/1/6 File src/compiler.h (right): http://codereview.chromium.org/551189/diff/1/6#newcode74 src/compiler.h:74: Handle<Object> receiver, I think you would do yourself a ...
10 years, 10 months ago (2010-01-28 16:28:51 UTC) #2
fschneider
10 years, 10 months ago (2010-01-29 09:58:03 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698