Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4438)

Unified Diff: chrome/browser/chromeos/notifications/balloon_collection_impl.cc

Issue 5511002: Notification UI should not be reset at browser-close, as the notification ui ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/notifications/balloon_collection_impl.cc
===================================================================
--- chrome/browser/chromeos/notifications/balloon_collection_impl.cc (revision 67892)
+++ chrome/browser/chromeos/notifications/balloon_collection_impl.cc (working copy)
@@ -138,12 +138,12 @@
const NotificationDetails& details) {
DCHECK(type == NotificationType::BROWSER_CLOSED);
bool app_closing = *Details<bool>(details).ptr();
- // When exitting, we need to shutdown all renderers in
+ // When exiting, we need to shutdown all renderers in
// BalloonViewImpl before IO thread gets deleted in the
// BrowserProcessImpl's destructor. See http://crbug.com/40810
// for details.
if (app_closing)
- Shutdown();
+ RemoveAll();
}
void BalloonCollectionImpl::Shutdown() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698