Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2149)

Unified Diff: nih/tests/test_child.c

Issue 551081: Do not run upstart tests with every build (Closed)
Patch Set: Fix comment as per code review Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « init/tests/test_job_process.c ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: nih/tests/test_child.c
diff --git a/nih/tests/test_child.c b/nih/tests/test_child.c
index 4c8c76055f168b8eb47f08bd6060b0968d765be1..282a6fa4a523251933597af6de47d1dd2c95db8b 100644
--- a/nih/tests/test_child.c
+++ b/nih/tests/test_child.c
@@ -327,6 +327,10 @@ test_poll (void)
waitid (P_PID, pid, &siginfo, WEXITED);
nih_free (watch);
+#if 0
+ /* The following tests fail on xen VM instances, hanging the
+ * machine. */
+ /* TODO(kmixter): understand why these fail of xen VMs */
/* Check that a signal raised from a traced child causes the reaper
* to be called with a traced event and the event in the status
@@ -624,6 +628,7 @@ test_poll (void)
kill (pid, SIGTERM);
waitpid (pid, NULL, 0);
+#endif
/* Check that a poll when there are no child processes does nothing */
« no previous file with comments | « init/tests/test_job_process.c ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698