Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: init/tests/test_job_process.c

Issue 551081: Do not run upstart tests with every build (Closed)
Patch Set: Fix comment as per code review Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | nih/tests/test_child.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: init/tests/test_job_process.c
diff --git a/init/tests/test_job_process.c b/init/tests/test_job_process.c
index d43fa6e049c9a28a10336de99da3bc3f91235549..734bc511b298b2fd2af4cdb99a0a0888d1d6413d 100644
--- a/init/tests/test_job_process.c
+++ b/init/tests/test_job_process.c
@@ -3829,6 +3829,11 @@ test_handler (void)
class->expect = EXPECT_NONE;
+#if 0
+ /* The following tests fail on xen VM instances, hanging the
+ * machine. */
+ /* TODO(kmixter): understand why these fail of xen VMs */
+
/* Check that a traced process has a signal delivered to it
* unchanged.
*/
@@ -3876,7 +3881,6 @@ test_handler (void)
class->expect = EXPECT_NONE;
-
/* Check that a new traced process which receives SIGTRAP doesn't
* have it delivered, and instead has its options set.
*/
@@ -4325,6 +4329,7 @@ test_handler (void)
nih_free (job);
}
+#endif
class->expect = EXPECT_NONE;
#if HAVE_VALGRIND_VALGRIND_H
« no previous file with comments | « no previous file | nih/tests/test_child.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698