Issue 551081: Do not run upstart tests with every build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 551081: Do not run upstart tests with every build (Closed)

Created:
10 years, 11 months ago by Jason Glasgow

Modified:
9 years, 7 months ago

Reviewers:
kmixter1, tedbo, drewry

CC:
chromium-os-reviews_googlegroups.com

Visibility:
Public.

Description

Do not run upstart tests with every build Disable the tests in upstart/nih and upstart/init because they are failing when delivering a signal to a child process. This has been reported to consume 100% CPU on virtual machines.

Patch Set 1 #

Patch Set 2 : Disable just failing features #

Total comments: 2

Patch Set 3 : Fix comment as per code review #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	init/tests/test_job_process.c	View	1 2	3 chunks	+6 lines, -1 line	0 comments	Download
	M	nih/tests/test_child.c	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kmixter1

LGTM I really wish I understood why this code hangs on a paravirtualized kernel but ...

10 years, 11 months ago (2010-01-20 18:12:35 UTC) #3

Expand Messages | Collapse Messages