Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 551073: Call xglMakeCurrent for each command buffer to allow for multiple GL contexts... (Closed)

Created:
10 years, 11 months ago by apatrick_chromium
Modified:
9 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews_googlegroups.com, apatrick_chromium, Paweł Hajdan Jr., Ken Russell (switch to Gerrit)
Visibility:
Public.

Description

Call xglMakeCurrent for each command buffer to allow for multiple GL contexts. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36683

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -28 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 4 chunks +43 lines, -26 lines 0 comments Download
A gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +39 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_processor.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_processor_unittest.cc View 1 2 3 4 4 chunks +13 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/x_utils.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
apatrick_chromium
10 years, 11 months ago (2010-01-20 00:02:01 UTC) #1
piman
http://codereview.chromium.org/551073/diff/3001/3007 File gpu/command_buffer/service/gpu_processor.cc (right): http://codereview.chromium.org/551073/diff/3001/3007#newcode40 gpu/command_buffer/service/gpu_processor.cc:40: if (!decoder_->MakeCurrent()) Can we do this lazily ? I'm ...
10 years, 11 months ago (2010-01-20 00:52:01 UTC) #2
apatrick_chromium
http://codereview.chromium.org/551073/diff/3001/3007 File gpu/command_buffer/service/gpu_processor.cc (right): http://codereview.chromium.org/551073/diff/3001/3007#newcode40 gpu/command_buffer/service/gpu_processor.cc:40: if (!decoder_->MakeCurrent()) On 2010/01/20 00:52:01, piman wrote: > Can ...
10 years, 11 months ago (2010-01-20 01:12:52 UTC) #3
piman
10 years, 11 months ago (2010-01-20 01:17:50 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698