Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: chrome/browser/extensions/extension_browsertests_misc.cc

Issue 551070: Revert 36541 (which went in without any commit log by some black magic). ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/all.gyp ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_browsertests_misc.cc
===================================================================
--- chrome/browser/extensions/extension_browsertests_misc.cc (revision 36549)
+++ chrome/browser/extensions/extension_browsertests_misc.cc (working copy)
@@ -89,17 +89,23 @@
host->render_view_host(), L"", L"testTabsAPI()", &result);
EXPECT_TRUE(result);
+#if defined(OS_WIN)
+ // http://crbug.com/29896 - tabs.detectLanguage is Windows only
+
// Test for compact language detection API. First navigate to a (static) html
// file with a French sentence. Then, run the test API in toolstrip1.html to
// actually call the language detection API through the existing extension,
// and verify that the language returned is indeed French.
FilePath language_url = extension_test_data_dir.AppendASCII(
"french_sentence.html");
- ui_test_utils::NavigateToURL(browser(), net::FilePathToFileURL(language_url));
+ ui_test_utils::NavigateToURL(
+ browser(),
+ GURL(language_url.ToWStringHack()));
ui_test_utils::ExecuteJavaScriptAndExtractBool(
host->render_view_host(), L"", L"testTabsLanguageAPI()", &result);
EXPECT_TRUE(result);
+#endif
}
IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, ExtensionViews) {
« no previous file with comments | « build/all.gyp ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698