Fix issue 571: display descriptive names for code objects from snapshot.

src/serialize.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 679 matching lines @@
 // time we need to use it to mark the space at the end of a page free (by
 // making it into a byte array).
 void Deserializer::ReadObject(int space_number,
                               Space* space,
                               Object** write_back) {
   int size = source_->GetInt() << kObjectAlignmentBits;
   Address address = Allocate(space_number, space, size);
   *write_back = HeapObject::FromAddress(address);
   Object** current = reinterpret_cast<Object**>(address);
   Object** limit = current + (size >> kPointerSizeLog2);
+  LOG(SnapshotPositionEvent(address, source_->position()));

[Erik Corry, 2010/01/18 15:47:51]

Putting this in an if (FLAG_log_snapshot_positions) would avoid the call, but if
you can't see the difference in benchmarks I guess it's not necessary.

   ReadChunk(current, limit, space_number, address);
 }
 
 
 #define ONE_CASE_PER_SPACE(base_tag)   \
   case (base_tag) + NEW_SPACE:         /* NOLINT */ \
   case (base_tag) + OLD_POINTER_SPACE: /* NOLINT */ \
   case (base_tag) + OLD_DATA_SPACE:    /* NOLINT */ \
   case (base_tag) + CODE_SPACE:        /* NOLINT */ \
   case (base_tag) + MAP_SPACE:         /* NOLINT */ \
@@ skipping 372 matching lines @@
   int size = object_->Size();
 
   if (reference_representation_ == TAGGED_REPRESENTATION) {
     sink_->Put(OBJECT_SERIALIZATION + space, "ObjectSerialization");
   } else {
     CHECK_EQ(CODE_TARGET_REPRESENTATION, reference_representation_);
     sink_->Put(CODE_OBJECT_SERIALIZATION + space, "ObjectSerialization");
   }
   sink_->PutInt(size >> kObjectAlignmentBits, "Size in words");
 
+  LOG(SnapshotPositionEvent(object_->address(), sink_->Position()));
+
   // Mark this object as already serialized.
   bool start_new_page;
   SerializationAddressMapper::Map(
     object_,
     serializer_->Allocate(space, size, &start_new_page));
   if (start_new_page) {
     sink_->Put(START_NEW_PAGE_SERIALIZATION, "NewPage");
     sink_->PutSection(space, "NewPageSpace");
   }
 
@@ skipping 173 matching lines @@
       fullness_[space] = RoundUp(fullness_[space], Page::kPageSize);
     }
   }
   int allocation_address = fullness_[space];
   fullness_[space] = allocation_address + size;
   return allocation_address;
 }
 
 
 } }  // namespace v8::internal