Issue 551049: Attempting to get rid of orange on the WebKit builders. Most of this is test...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 551049: Attempting to get rid of orange on the WebKit builders. Most of this is test... (Closed)

Created:
10 years, 11 months ago by Stephen White

Modified:
9 years, 7 months ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Attempting to get rid of orange on the WebKit builders. Most of this is test_expectations cleanup. Removed the Win and Linux baselines for fast/backgrounds/svg-as-mask, since they're incorrect (it's still not passing). BUG=10296, 23473, 12030, 21411, 30048, 32154, 32307 TEST=green bots TBR=atwilson Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36354

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -27 lines)			Patch
D	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/backgrounds/svg-as-mask-expected.checksum	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/backgrounds/svg-as-mask-expected.png	View	Binary file		0 comments	Download
D	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/svg-as-mask-expected.checksum	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/svg-as-mask-expected.png	View	Binary file		0 comments	Download
D	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/svg-as-mask-expected.txt	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	9 chunks	+12 lines, -16 lines	0 comments	Download

Total messages: 2 (0 generated)

Andrew T Wilson (Slow)

10 years, 11 months ago (2010-01-15 17:54:05 UTC) #2

On 2010/01/15 16:30:36, Stephen White wrote:
> 
LGTM. Thanks for catching this!