Issue 551043: Hook third_party/chromeos_text_input to all.gyp for Chromium OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 551043: Hook third_party/chromeos_text_input to all.gyp for Chromium OS. (Closed)

Created:
10 years, 11 months ago by satorux1

Modified:
9 years, 7 months ago

Reviewers:
oshima

CC:
chromium-reviews_googlegroups.com, Yusuke Sato

Visibility:
Public.

Description

Hook third_party/chromeos_text_input to all.gyp for Chromium OS. chromiumos_text_input contains IME candidate window code which is part of text input suppport for Chromium OS. See the design doc for details: http://www.chromium.org/chromium-os/chromiumos-design-docs/text-input BUG=none TEST=confirmed gclient --runhooks work with and without GYP_DEFINES="chromeos=1". Also confirmed that 'candidate_window' target is only valid and built when GYP_DEFINES="chromeos=1" is set. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36484

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	build/all.gyp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

satorux1

Oshima-san, Could you take a look at this? I assume you are the person most ...

10 years, 11 months ago (2010-01-15 09:32:32 UTC) #1

oshima

10 years, 11 months ago (2010-01-15 22:49:05 UTC) #2

LGTM, but can you  this passes the "linux_view" and "linux_chromeos" trybots
before committing?

On 2010/01/15 09:32:32, satorux1 wrote:
> Oshima-san,
> 
> Could you take a look at this? I assume you are the person most familiar with
> .gyp file changes for chromeos==1. :)

Expand Messages | Collapse Messages